LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Yong Zhang <yong.zhang0@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Ingo Molnar" <mingo@elte.hu>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
	"Mike Galbraith" <mgalbraith@suse.de>,
	"Luis Claudio R. Gon�alves" <lgoncalv@redhat.com>,
	"Matthew Hank Sabins" <msabins@linux.vnet.ibm.com>,
	"Gregory Haskins" <gregory.haskins@gmail.com>,
	"Andrew Morton" <akpm@linux-foundation.org>
Subject: [PATCH V2] sched/cpupri: Remove cpupri->pri_active
Date: Sat, 6 Aug 2011 08:10:04 +0800
Message-ID: <20110806001004.GA2207@zhy> (raw)
In-Reply-To: <1312558000.18583.201.camel@gandalf.stny.rr.com>

On Fri, Aug 05, 2011 at 11:26:40AM -0400, Steven Rostedt wrote:
> On Fri, 2011-08-05 at 22:38 +0800, Yong Zhang wrote:
> 
> > Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
> > ---
> >  kernel/sched_cpupri.c |    3 ---
> >  kernel/sched_cpupri.h |    2 --
> >  2 files changed, 0 insertions(+), 5 deletions(-)
> > 
> > diff --git a/kernel/sched_cpupri.c b/kernel/sched_cpupri.c
> > index 90faffd..5839559 100644
> > --- a/kernel/sched_cpupri.c
> > +++ b/kernel/sched_cpupri.c
> > @@ -151,9 +151,6 @@ void cpupri_set(struct cpupri *cp, int cpu, int newpri)
> >  	/*
> >  	 * If the cpu was currently mapped to a different value, we
> >  	 * need to map it to the new value then remove the old value.
> > -	 * Note, we must add the new value first, otherwise we risk the
> > -	 * cpu being cleared from pri_active, and this cpu could be
> > -	 * missed for a push or pull.
> 
> Actually, the above still holds true, just not for pri_active. Probably
> should be changed to:
> 
> 	* Note, we must add the new value first, otherwise we risk the
> 	* cpu being missed by the priority loop in cpupri_find.
> 
> or something as such.

Updated.

Thanks,
Yong

---
From: Yong Zhang <yong.zhang0@gmail.com>
Subject: [PATCH V2] sched/cpupri: Remove cpupri->pri_active

Since [sched/cpupri: Remove the vec->lock], member pri_active
of struct cpupri is not needed any more, just remove it. Also
clean stuff related to it.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
---
 kernel/sched_cpupri.c |    3 +--
 kernel/sched_cpupri.h |    2 --
 2 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/kernel/sched_cpupri.c b/kernel/sched_cpupri.c
index 90faffd..a86cf9d 100644
--- a/kernel/sched_cpupri.c
+++ b/kernel/sched_cpupri.c
@@ -152,8 +152,7 @@ void cpupri_set(struct cpupri *cp, int cpu, int newpri)
 	 * If the cpu was currently mapped to a different value, we
 	 * need to map it to the new value then remove the old value.
 	 * Note, we must add the new value first, otherwise we risk the
-	 * cpu being cleared from pri_active, and this cpu could be
-	 * missed for a push or pull.
+	 * cpu being missed by the priority loop in cpupri_find.
 	 */
 	if (likely(newpri != CPUPRI_INVALID)) {
 		struct cpupri_vec *vec = &cp->pri_to_cpu[newpri];
diff --git a/kernel/sched_cpupri.h b/kernel/sched_cpupri.h
index 6b4cd17..f6d7561 100644
--- a/kernel/sched_cpupri.h
+++ b/kernel/sched_cpupri.h
@@ -4,7 +4,6 @@
 #include <linux/sched.h>
 
 #define CPUPRI_NR_PRIORITIES	(MAX_RT_PRIO + 2)
-#define CPUPRI_NR_PRI_WORDS	BITS_TO_LONGS(CPUPRI_NR_PRIORITIES)
 
 #define CPUPRI_INVALID -1
 #define CPUPRI_IDLE     0
@@ -18,7 +17,6 @@ struct cpupri_vec {
 
 struct cpupri {
 	struct cpupri_vec pri_to_cpu[CPUPRI_NR_PRIORITIES];
-	long              pri_active[CPUPRI_NR_PRI_WORDS];
 	int               cpu_to_pri[NR_CPUS];
 };
 
-- 
1.7.1


  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02 20:36 [PATCH][GIT PULL] sched/cpupri: Remove the vec->lock Steven Rostedt
2011-08-03 14:18 ` Hillf Danton
2011-08-03 14:49   ` Steven Rostedt
2011-08-05 13:16     ` Hillf Danton
2011-08-03 14:29 ` Peter Zijlstra
2011-08-04 20:32 ` [PATCH] cpupri: Fix memory barriers for vec updates to always be in order Steven Rostedt
2011-08-05 12:27   ` [PATCH v2] " Steven Rostedt
2011-08-14 16:12     ` [tip:sched/core] sched/cpupri: " tip-bot for Steven Rostedt
2011-08-05  8:20 ` [PATCH][GIT PULL] sched/cpupri: Remove the vec->lock Yong Zhang
2011-08-05 12:30   ` Steven Rostedt
2011-08-05 14:38     ` [PATCH] sched/cpupri: Remove cpupri->pri_active Yong Zhang
2011-08-05 15:26       ` Steven Rostedt
2011-08-06  0:10         ` Yong Zhang [this message]
2011-08-14 16:13           ` [tip:sched/core] " tip-bot for Yong Zhang

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110806001004.GA2207@zhy \
    --to=yong.zhang0@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=gregory.haskins@gmail.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgalbraith@suse.de \
    --cc=mingo@elte.hu \
    --cc=msabins@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git