linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
	devel@linuxdriverproject.org, virtualization@lists.osdl.org
Subject: Re: Hyper-V TODO file
Date: Fri, 2 Sep 2011 09:09:24 -0700	[thread overview]
Message-ID: <20110902160924.GA4784@kroah.com> (raw)
In-Reply-To: <20110901203031.GB15185@kroah.com>

On Thu, Sep 01, 2011 at 01:30:31PM -0700, Greg KH wrote:
> On Thu, Sep 01, 2011 at 01:27:33PM -0700, Greg KH wrote:
> > On Wed, Aug 31, 2011 at 03:16:51PM -0700, K. Y. Srinivasan wrote:
> > > 2) With your help, we have fixed all of the issues related to these drivers
> > > conforming to the Linux Device Driver model. One of the TODO work items is 
> > > "audit the vmbus to verify it is working properly with the driver model".
> > 
> > I have a few comments about this, I'll respond in another email.
> 
> Ok, it looks a _lot_ better, but I have a few minor nits, and one larger
> one:

Oh, here's another issue I forgot about.  You can get rid of the 'ext'
field of the hv_device structure and use the proper function in the
driver core for this type of thing, just wrap it up in your own function
to make it "sane" looking, like USB and PCI does with their
usb_get_intfdata(), usb_set_intfdata(), pci_get_drvdata(), and
pci_set_drvdata() functions.

thanks,

greg k-h

  parent reply	other threads:[~2011-09-02 16:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31 22:16 Hyper-V TODO file K. Y. Srinivasan
2011-08-31 23:11 ` Peter Foley
2011-09-01 20:31   ` Greg KH
2011-09-02 14:09     ` KY Srinivasan
2011-09-02 15:17     ` KY Srinivasan
2011-09-02 16:03       ` Greg KH
2011-09-01 20:27 ` Greg KH
2011-09-01 20:30   ` Greg KH
2011-09-01 21:08     ` KY Srinivasan
2011-09-02 16:09     ` Greg KH [this message]
2011-09-02 19:47     ` KY Srinivasan
2011-09-02 19:58       ` Greg KH
2011-09-02 20:54         ` KY Srinivasan
2011-09-01 20:57   ` KY Srinivasan
2011-09-22 16:17 K. Y. Srinivasan
2011-09-22 16:05 ` Joe Perches
2011-09-22 17:04 ` Greg KH
2011-09-22 17:20   ` KY Srinivasan
2011-09-22 17:36     ` Greg KH
2011-09-22 18:22       ` KY Srinivasan
2011-10-04 13:59       ` KY Srinivasan
2011-10-04 17:04         ` Greg KH
2011-10-04 17:23           ` KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110902160924.GA4784@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@suse.de \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).