From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: alsa-devel@alsa-project.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Dmitry Artamonow <mad_soft@inbox.ru>,
linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH 2/6] ASoC: codecs: AK4641 depends on GPIOLIB
Date: Mon, 3 Oct 2011 17:34:41 +0100 [thread overview]
Message-ID: <20111003163441.GH23811@sirena.org.uk> (raw)
In-Reply-To: <9353092.2X2OeIUYGE@wuerfel>
On Mon, Oct 03, 2011 at 06:19:48PM +0200, Arnd Bergmann wrote:
> When the GPIO API is stubbed out, the definition of struct gpio
> is empty, so you cannot access the members, which seems to be
> intentional behavior.
That doesn't seem terribly helpful, it means drivers either need to
ifdef or not use the bulk functions.
> struct device;
> -struct gpio;
> +struct gpio {
> + unsigned gpio;
> + unsigned long flags;
> + const char *label;
> +};
This looks much more sensible to me.
> select SND_SOC_WL1273 if MFD_WL1273_CORE
> - select SND_SOC_WM1250_EV1 if I2C
> + select SND_SOC_WM1250_EV1 if I2C && GENERIC_GPIO
Or ifdefs in the driver.
next prev parent reply other threads:[~2011-10-03 16:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 20:27 [PATCH 0/6] ASoC fixes from ARM randconfig builds Arnd Bergmann
2011-10-02 20:27 ` [PATCH 1/6] ASoC: codecs/wm8682: use __devexit_p Arnd Bergmann
2011-10-02 20:36 ` Mark Brown
2011-10-02 20:28 ` [PATCH 2/6] ASoC: codecs: AK4641 depends on GPIOLIB Arnd Bergmann
2011-10-02 20:41 ` Mark Brown
2011-10-02 20:53 ` Arnd Bergmann
2011-10-02 21:27 ` Mark Brown
2011-10-03 10:59 ` Arnd Bergmann
2011-10-03 13:45 ` Russell King - ARM Linux
2011-10-03 14:35 ` [alsa-devel] " Mark Brown
2011-10-03 14:47 ` Arnd Bergmann
2011-10-03 15:20 ` Mark Brown
2011-10-03 16:19 ` Arnd Bergmann
2011-10-03 16:34 ` Mark Brown [this message]
2011-10-02 20:28 ` [PATCH 3/6] ASoC: imx: eukrea_tlv320 needs i2c Arnd Bergmann
2011-10-02 20:49 ` Mark Brown
2011-10-02 20:28 ` [PATCH 4/6] ASoC: sh: use correct __iomem annotations Arnd Bergmann
2011-10-02 20:50 ` Mark Brown
2011-10-02 21:20 ` Arnd Bergmann
2011-10-02 20:28 ` [PATCH 5/6] ASoC: samsung: fix Kconfig dependencies Arnd Bergmann
2011-10-02 20:47 ` Mark Brown
2011-10-02 21:14 ` Arnd Bergmann
2011-10-02 21:29 ` Mark Brown
2011-10-03 6:48 ` [alsa-devel] " Sangbeom Kim
2011-10-03 11:50 ` Arnd Bergmann
2011-10-03 12:07 ` Mark Brown
2011-10-03 13:43 ` [PATCH 5/6] ASoC: samsung: wm8994 depends on mfd_wm8994 Arnd Bergmann
2011-10-03 14:08 ` Mark Brown
2011-10-03 14:35 ` [PATCH v3] " Arnd Bergmann
2011-10-03 14:40 ` Mark Brown
2011-10-02 20:28 ` [PATCH 6/6] ASoC: samsung: add missing __devexit_p() annotations Arnd Bergmann
2011-10-02 20:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111003163441.GH23811@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@ti.com \
--cc=mad_soft@inbox.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).