From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Xi Wang <xi.wang@gmail.com>
Cc: linux-kernel@vger.kernel.org, Joerg Reuter <jreuter@yaina.de>,
Ralf Baechle <ralf@linux-mips.org>,
David Miller <davem@davemloft.net>,
linux-hams@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] ax25: integer overflows in ax25_setsockopt()
Date: Wed, 23 Nov 2011 10:44:49 +0000 [thread overview]
Message-ID: <20111123104449.5e845a0f@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <7187C142-99F1-4A96-9BE6-650B10C9B22D@gmail.com>
> case AX25_T1:
> - if (opt < 1) {
> + if (opt < 1 || opt > 30) {
Where do these values come from ? If they are from some 'standard' then
really we should avoid restricting needlessly to it, particularly as
AX.25 isn't well defined and is used for all sorts of crazy stuff where
the usual range of settings isn't useful.
Restricting to the point it would overflow makes sense however.
Alan
next prev parent reply other threads:[~2011-11-23 10:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 4:28 [PATCH 1/2] ax25: integer overflows in ax25_setsockopt() Xi Wang
2011-11-23 10:44 ` Alan Cox [this message]
2011-11-23 14:04 ` Xi Wang
2011-11-23 14:39 ` Alan Cox
2011-11-23 14:53 ` David Laight
2011-11-23 17:09 ` Ralf Baechle
2011-11-24 19:09 ` Xi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123104449.5e845a0f@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=jreuter@yaina.de \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).