From: Daniel Vetter <daniel@ffwll.ch>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Daniel Vetter <daniel@ffwll.ch>,
rajesh.sankaran@intel.com, Keith Packard <keithp@keithp.com>,
Matthew Garrett <mjg@redhat.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: By default, enable RC6 on IVB and SNB when reasonable
Date: Wed, 23 Nov 2011 21:35:42 +0100 [thread overview]
Message-ID: <20111123203542.GI3864@phenom.ffwll.local> (raw)
In-Reply-To: <1322062985.15493.176.camel@shinybook.infradead.org>
On Wed, Nov 23, 2011 at 03:43:05PM +0000, David Woodhouse wrote:
> On Wed, 2011-11-23 at 16:41 +0100, Daniel Vetter wrote:
> > Hm, that comment confuses me a bit. I've always thought that igfx_off only
> > instantiates a identity mapping and leaves the dmar unit on. Is that
> > wrong?
>
> It's completely off. If a DMAR unit has *only* graphics devices behind
> it (as the one for the built-in graphics does, because it's a whole
> boatload of speshul case for integration with the GTT), we just don't
> enable it at all. See the second for_each_drhd_unit() loop in
> init_no_remapping_devices().
That explanation confused me even more. So I've rechecked with
intel_iommu=igfx_off and already thought I've made a decent fool of
myself because I couldn't readily hang it. Turns out it's just much harder
to hang with that. So I think moving around the tlb flushing for other
dmar nodes to align with the idled igfx isn't a great solution, simply
because I can't reliably tell whether it fixes anything.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2011-11-23 20:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-19 6:41 [PATCH] drm/i915: By default, enable RC6 on IVB and SNB when reasonable Keith Packard
2011-11-19 7:37 ` [Intel-gfx] " Kenneth Graunke
2011-11-19 9:25 ` Eugeni Dodonov
2011-11-19 18:32 ` Keith Packard
2011-11-20 21:19 ` Eugeni Dodonov
2011-11-22 20:15 ` Matthew Garrett
[not found] ` <CAC7Lmnts+QwZ2XTvbTQa=aa3XO5_Sna0vk3KHWJJ6oi6+D5BXw@mail.gmail.com>
2011-11-22 20:51 ` Matthew Garrett
2011-11-23 3:31 ` Keith Packard
2011-11-23 10:26 ` Daniel Vetter
2011-11-23 14:01 ` David Woodhouse
2011-11-23 14:39 ` Daniel Vetter
2011-11-23 15:03 ` David Woodhouse
2011-11-23 15:31 ` Daniel Vetter
2011-11-23 15:36 ` David Woodhouse
2011-11-23 15:46 ` Daniel Vetter
2011-11-23 15:41 ` Daniel Vetter
2011-11-23 15:43 ` David Woodhouse
2011-11-23 20:35 ` Daniel Vetter [this message]
2011-11-23 18:42 ` [PATCH] iommu: export no_iommu and dmar_disabled symbols Eugeni Dodonov
2011-11-23 20:36 ` [Intel-gfx] " David Woodhouse
2011-11-23 20:48 ` Keith Packard
[not found] ` <1322526298-2746-1-git-send-email-eugeni.dodonov@intel.com>
2011-12-09 23:53 ` drm/i915: Enabling RC6 where possible Keith Packard
2011-12-09 23:53 ` [PATCH 1/2] iommu: Export intel_iommu_enabled to signal when iommu is in use Keith Packard
2011-12-09 23:53 ` [PATCH 2/2] drm/i915: By default, enable RC6 on IVB and SNB when reasonable Keith Packard
2011-12-13 3:45 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123203542.GI3864@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=dwmw2@infradead.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=rajesh.sankaran@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).