linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Xi Wang <xi.wang@gmail.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	Mori Hess <fmhess@users.sourceforge.net>,
	"security@kernel.org" <security@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Ian Abbott <ian.abbott@mev.co.uk>,
	Lucas De Marchi <lucas.demarchi@profusion.mobi>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ian Abbott <abbotti@mev.co.uk>, Franky Lin <frankyl@broadcom.com>,
	Greg Dietsche <Gregory.Dietsche@cuw.edu>,
	Mark Pearson <markpearson_de@yahoo.de>
Subject: Re: [PATCH] comedi: integer overflow in do_insnlist_ioctl()
Date: Fri, 25 Nov 2011 10:25:50 +0300	[thread overview]
Message-ID: <20111125072550.GK3195@mwanda> (raw)
In-Reply-To: <97189E06-26D8-4CF9-B325-06403FB1C42C@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

On Thu, Nov 24, 2011 at 02:07:49PM -0500, Xi Wang wrote:
> Using kcalloc looks good to me.  Do you want to redo the patch in that way?
> 

It's your choice.  The other fix you wrote is valid as well.

regards,
dan carpenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2011-11-25  7:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23  0:49 [PATCH] comedi: integer overflow in do_insnlist_ioctl() Xi Wang
2011-11-23  6:13 ` Dan Carpenter
2011-11-23 13:59   ` Xi Wang
2011-11-23 14:50     ` Dan Carpenter
2011-11-23 16:06       ` Ian Abbott
2011-11-23 16:53         ` [PATCH v2] " Xi Wang
2011-11-23 21:41         ` [PATCH] " Lars-Peter Clausen
2011-11-23 21:51           ` Dan Carpenter
2011-11-24 19:07             ` Xi Wang
2011-11-25  7:25               ` Dan Carpenter [this message]
2011-11-25 21:46                 ` [PATCH v3] " Xi Wang
2011-11-27  2:52                   ` Greg KH
2011-11-27 11:25                     ` Dan Carpenter
2011-11-27 21:24                       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111125072550.GK3195@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=Gregory.Dietsche@cuw.edu \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=fmhess@users.sourceforge.net \
    --cc=frankyl@broadcom.com \
    --cc=gregkh@suse.de \
    --cc=ian.abbott@mev.co.uk \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=markpearson_de@yahoo.de \
    --cc=security@kernel.org \
    --cc=xi.wang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).