From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754882Ab1K2R1H (ORCPT ); Tue, 29 Nov 2011 12:27:07 -0500 Received: from fieldses.org ([174.143.236.118]:56211 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753457Ab1K2R1F (ORCPT ); Tue, 29 Nov 2011 12:27:05 -0500 Date: Tue, 29 Nov 2011 12:27:02 -0500 From: "J. Bruce Fields" To: Trond Myklebust Cc: Peng Tao , tao.peng@emc.com, skinsbursky@parallels.com, linux-nfs@vger.kernel.org, xemul@parallels.com, neilb@suse.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jbottomley@parallels.com, davem@davemloft.net, devel@openvz.org Subject: Re: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routines Message-ID: <20111129172702.GB19528@fieldses.org> References: <4ED4CDCE.9080804@parallels.com> <2E1EB2CF9ED1CB4AA966F0EB76EAB4430C3CBC23@SACMVEXC2-PRD.hq.netapp.com> <1322579906.3619.1.camel@lade.trondhjem.org> <1322584830.4174.16.camel@lade.trondhjem.org> <20111129164252.GA19528@fieldses.org> <1322587165.4174.20.camel@lade.trondhjem.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1322587165.4174.20.camel@lade.trondhjem.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 29, 2011 at 12:19:25PM -0500, Trond Myklebust wrote: > On Tue, 2011-11-29 at 11:42 -0500, J. Bruce Fields wrote: > > On Tue, Nov 29, 2011 at 11:40:30AM -0500, Trond Myklebust wrote: > > > I mean that I'm perfectly entitled to do > > > > > > 'modprobe -r blocklayoutdriver' > > > > > > and when I do that, then I expect blkmapd to close the rpc pipe and wait > > > for a new one to be created just like rpc.idmapd and rpc.gssd do when I > > > remove the nfs and sunrpc modules. > > > > The rpc pipefs mount doesn't hold a reference on the sunrpc module? > > I stand corrected: the mount does hold a reference to the sunrpc > module. > However nothing holds a reference to the blocklayoutdriver module, so > the main point that the "blocklayout" pipe can disappear from underneath > the blkmapd stands. OK, that makes sense. --b.