linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Richter <robert.richter@amd.com>
To: Stephane Eranian <eranian@google.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	"acme@redhat.com" <acme@ghostprotocols.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"dsahern@gmail.com" <dsahern@gmail.com>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	"mingo@elte.hu" <mingo@elte.hu>
Subject: Re: [PATCH] perf: make perf.data more self-descriptive (v8)
Date: Mon, 5 Dec 2011 14:23:40 +0100	[thread overview]
Message-ID: <20111205132340.GH15738@erda.amd.com> (raw)
In-Reply-To: <CABPqkBQwQ1gzQEfAehiLRXrO196vovNeRjS9taiM7dfk7U9egQ@mail.gmail.com>

On 01.12.11 09:53:10, Stephane Eranian wrote:
> On Thu, Dec 1, 2011 at 7:15 AM, Robert Richter <robert.richter@amd.com> wrote:
> > I am asking this because I want to change code in a way that treats
> > all features the same, that is just to disable the feature bit on
> > failure and then continue anyway.
> >
> You need to make sure that disabling the bit is enough to still get a consistent
> file, i.e., want to undo the effect of writing the feature to the
> file. In the case
> of the meta-data features I added that was easy simply lseek() back to
> the position
> before the call. Would that be the case with TRACE_INFO?

It should be. All features can be parsed independently. Offset and
size of a feature's data block is stored in struct perf_file_section
right after the data block of perf.data (see perf_session__write_
header()). Thus, if a feature does not exist then other features can
be processed anyway.

Thanks,

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center


  reply	other threads:[~2011-12-05 13:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-30 13:40 [PATCH] perf: make perf.data more self-descriptive (v8) Stephane Eranian
2011-10-04  4:50 ` David Ahern
2011-11-29 18:22 ` Robert Richter
2011-11-29 18:35   ` Stephane Eranian
2011-11-30 15:08     ` Robert Richter
2011-11-30 16:49       ` acme
2011-12-01 15:01         ` Frederic Weisbecker
2011-12-01 15:15           ` Robert Richter
2011-12-01 17:53             ` Stephane Eranian
2011-12-05 13:23               ` Robert Richter [this message]
2011-12-05 19:24                 ` Stephane Eranian
2011-12-06  9:29                   ` Robert Richter
     [not found]                     ` <CABPqkBRbdJ0tG2+V-CvEdPnwm5YqQuv7FKrUHoTM8=wa8V=kHQ@mail.gmail.com>
2011-12-19  9:26                       ` Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111205132340.GH15738@erda.amd.com \
    --to=robert.richter@amd.com \
    --cc=acme@ghostprotocols.net \
    --cc=ak@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).