From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Thomas Jarosch <thomas.jarosch@intra2net.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Charlie Suffin <charlie.suffin@stratus.com>,
stable@kernel.org
Subject: Re: [PATCH] pci: Add quirk for still enabled interrupts on Intel Sandy Bridge GPUs
Date: Wed, 7 Dec 2011 13:30:00 -0800 [thread overview]
Message-ID: <20111207133000.69051c59@jbarnes-desktop> (raw)
In-Reply-To: <4EDFD5BB.1050906@intra2net.com>
[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]
On Wed, 07 Dec 2011 22:08:11 +0100
Thomas Jarosch <thomas.jarosch@intra2net.com> wrote:
> +#define I915_DEIER_REG 0x4400c
> +static void __devinit disable_igfx_irq(struct pci_dev *dev)
> +{
> + void __iomem *regs = pci_iomap(dev, 0, 0);
> + if (regs == NULL) {
> + dev_warn(&dev->dev, "igfx quirk: Can't iomap PCI device\n");
> + return;
> + }
> +
> + /* Check if any interrupt line is still enabled */
> + if (readl(regs + I915_DEIER_REG) != 0) {
> + dev_warn(&dev->dev, "BIOS left Intel GPU interrupts enabled; "
> + "disabling\n");
> +
> + writel(0, regs + I915_DEIER_REG);
> + }
> +
> + pci_iounmap(dev, regs);
> +}
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0102, disable_igfx_irq);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x010a, disable_igfx_irq);
> +
> static void pci_do_fixups(struct pci_dev *dev, struct pci_fixup *f,
> struct pci_fixup *end)
> {
Could really be dev_dbg, I think this will be fairly common. I think we
also need to ack any outstanding interrupts after disabling them in IER
by writing IIR back on itself. Can you test that?
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-12-07 21:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 21:08 [PATCH] pci: Add quirk for still enabled interrupts on Intel Sandy Bridge GPUs Thomas Jarosch
2011-12-07 21:30 ` Jesse Barnes [this message]
2011-12-08 8:27 ` Thomas Jarosch
2012-01-10 10:45 ` Thomas Jarosch
2012-01-27 17:28 ` Jesse Barnes
2012-01-31 8:20 ` Thomas Jarosch
2012-02-10 19:45 ` Jesse Barnes
2012-04-25 15:22 ` Thomas Jarosch
2012-04-25 15:23 ` Drew Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207133000.69051c59@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=charlie.suffin@stratus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=stable@kernel.org \
--cc=thomas.jarosch@intra2net.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).