linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Andrew Vagin <avagin@openvz.org>
Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
	paulus@samba.org, mingo@elte.hu, asharma@fb.com,
	devel@openvz.org, dsahern@gmail.com,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf: add ability to record event period
Date: Tue, 20 Dec 2011 15:20:19 -0200	[thread overview]
Message-ID: <20111220172019.GE28058@infradead.org> (raw)
In-Reply-To: <1324391565-1369947-1-git-send-email-avagin@openvz.org>

Em Tue, Dec 20, 2011 at 05:32:45PM +0300, Andrew Vagin escreveu:
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 766fa0a..f8fd14f 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -700,6 +700,7 @@ const struct option record_options[] = {
>  	OPT_BOOLEAN('d', "data", &record.opts.sample_address,
>  		    "Sample addresses"),
>  	OPT_BOOLEAN('T', "timestamp", &record.opts.sample_time, "Sample timestamps"),
> +	OPT_BOOLEAN('P', "period", &record.opts.period, "Sample period"),
>  	OPT_BOOLEAN('n', "no-samples", &record.opts.no_samples,
>  		    "don't sample"),
>  	OPT_BOOLEAN('N', "no-buildid-cache", &record.no_buildid_cache,

You forgot to update the tools/perf/Documentation/perf-record.txt tho.

I'm doing this for you this time, please take that into account next
time.

Regards and thanks for iterating thru this and working on perf!

- Arnaldo

  reply	other threads:[~2011-12-20 17:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-20 14:32 [PATCH] perf: add ability to record event period Andrew Vagin
2011-12-20 17:20 ` Arnaldo Carvalho de Melo [this message]
2011-12-21  8:40 ` [tip:perf/core] perf record: Add " tip-bot for Andrew Vagin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111220172019.GE28058@infradead.org \
    --to=acme@infradead.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=asharma@fb.com \
    --cc=avagin@openvz.org \
    --cc=devel@openvz.org \
    --cc=dsahern@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).