From: Frederic Weisbecker <fweisbec@gmail.com>
To: Mandeep Singh Baines <msb@chromium.org>
Cc: Oleg Nesterov <oleg@redhat.com>, Li Zefan <lizf@cn.fujitsu.com>,
Tejun Heo <tj@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Containers <containers@lists.linux-foundation.org>,
Cgroups <cgroups@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Paul Menage <paul@paulmenage.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: Q: cgroup: Questions about possible issues in cgroup locking
Date: Wed, 21 Dec 2011 20:08:20 +0100 [thread overview]
Message-ID: <20111221190817.GI17668@somewhere> (raw)
In-Reply-To: <20111221190102.GE13529@google.com>
On Wed, Dec 21, 2011 at 11:01:02AM -0800, Mandeep Singh Baines wrote:
> Frederic Weisbecker (fweisbec@gmail.com) wrote:
> > On Wed, Dec 21, 2011 at 02:08:48PM +0100, Oleg Nesterov wrote:
> > > On 12/21, Frederic Weisbecker wrote:
> > > > Hi,
> > > >
> > > > Starring at some parts of cgroups, I have a few questions:
> > > >
> > > > - Is cgroup_enable_task_cg_list()'s while_each_thread() safe
> > > > against concurrent exec()? The leader may change in de_thread()
> > > > and invalidate the test done in while_each_thread().
> > >
> > > Yes. Oh, we need to do something with while_each_thread.
> >
> > Would something like this work?
> >
> > diff --git a/include/linux/sched.h b/include/linux/sched.h
> > index c0c5876..e002a00 100644
> > --- a/include/linux/sched.h
> > +++ b/include/linux/sched.h
> > @@ -2293,8 +2293,12 @@ extern bool current_is_single_threaded(void);
> > #define do_each_thread(g, t) \
> > for (g = t = &init_task ; (g = t = next_task(g)) != &init_task ; ) do
> >
> > -#define while_each_thread(g, t) \
> > - while ((t = next_thread(t)) != g)
> > +#define while_each_thread(g, t) \
> > + while (({ \
> > + struct task_struct *__prev = t; \
> > + t = next_thread(t); \
> > + t != __prev && t != g; \
>
> Hi,
>
> Don't you still have an (highly unlikely) race if you exec
> and then pthread_create()?
I'm not sure what you mean.
>
> Instead of:
>
> t != __prev && t != g;
>
> How about:
>
> t != t->group_leader;
That might work too but we need a pair of memory barriers.
next prev parent reply other threads:[~2011-12-21 19:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 3:43 Q: cgroup: Questions about possible issues in cgroup locking Frederic Weisbecker
2011-12-21 13:08 ` Oleg Nesterov
2011-12-21 17:56 ` Frederic Weisbecker
2011-12-21 19:01 ` Mandeep Singh Baines
2011-12-21 19:08 ` Frederic Weisbecker [this message]
2011-12-21 19:24 ` Mandeep Singh Baines
2011-12-21 20:04 ` Frederic Weisbecker
2011-12-22 15:30 ` Oleg Nesterov
2012-01-04 19:36 ` Mandeep Singh Baines
2012-01-06 15:23 ` Oleg Nesterov
2012-01-06 18:25 ` Mandeep Singh Baines
2012-01-11 16:07 ` Oleg Nesterov
2012-01-12 0:31 ` Mandeep Singh Baines
2012-01-12 17:07 ` Oleg Nesterov
2012-01-12 17:57 ` Mandeep Singh Baines
2012-01-13 15:20 ` Oleg Nesterov
2012-01-13 18:27 ` Mandeep Singh Baines
2012-01-14 17:36 ` Oleg Nesterov
2012-01-18 23:17 ` Mandeep Singh Baines
2012-01-19 15:45 ` Oleg Nesterov
2012-01-19 18:18 ` Mandeep Singh Baines
2012-01-20 15:06 ` Oleg Nesterov
2012-03-20 19:34 ` Oleg Nesterov
2012-03-21 18:59 ` Mandeep Singh Baines
2012-03-23 17:51 ` Oleg Nesterov
2011-12-21 17:59 ` Frederic Weisbecker
2011-12-21 18:11 ` Oleg Nesterov
2011-12-21 18:23 ` Frederic Weisbecker
2012-02-01 16:28 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221190817.GI17668@somewhere \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=msb@chromium.org \
--cc=oleg@redhat.com \
--cc=paul@paulmenage.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).