From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755269Ab1LVM4N (ORCPT ); Thu, 22 Dec 2011 07:56:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14122 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813Ab1LVM4K (ORCPT ); Thu, 22 Dec 2011 07:56:10 -0500 Date: Thu, 22 Dec 2011 13:55:58 +0100 From: Jiri Olsa To: Frederic Weisbecker Cc: rostedt@goodmis.org, mingo@redhat.com, paulus@samba.org, acme@ghostprotocols.net, a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org, aarapov@redhat.com Subject: Re: [PATCH 7/7] ftrace, perf: Add filter support for function trace event Message-ID: <20111222125558.GB1646@m.brq.redhat.com> References: <1324468136-3997-1-git-send-email-jolsa@redhat.com> <1324493791-5688-1-git-send-email-jolsa@redhat.com> <1324493791-5688-8-git-send-email-jolsa@redhat.com> <20111221220756.GL17668@somewhere> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111221220756.GL17668@somewhere> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 21, 2011 at 11:07:58PM +0100, Frederic Weisbecker wrote: > On Wed, Dec 21, 2011 at 07:56:31PM +0100, Jiri Olsa wrote: > > Adding support to filter function trace event via perf > > interface. It is now possible to use filter interface > > in the perf tool like: > > > > perf record -e ftrace:function --filter="(ip == mm_*)" ls > > > > The filter syntax is restricted to the the 'ip' field only, > > and following operators are accepted '==' '!=' '||', ending > > up with the filter strings like: > > > > "ip == f1 f2 ..." || "ip != f3 f4 ..." ... > > Having the functions seperated like this sort of violates the > grammar of the filtering interface. > > The typical way to do this would have been to stringify the > functions: ip == "f1 f2" > > I feel a bit uncomfortable with "ip == f1 f2" scheme but perhaps > we can live with that. Especially as otherwise that would > require us to type "ip == \"f1 f2\"" for the whole filtering expression. ugh, just realized there's a problem with this in the patch actually, and it's not working as expected. I'll send out new version soon.. thanks, jirka > > Thoughts?