From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754482Ab1L0ORZ (ORCPT ); Tue, 27 Dec 2011 09:17:25 -0500 Received: from cantor2.suse.de ([195.135.220.15]:45814 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754386Ab1L0ORJ (ORCPT ); Tue, 27 Dec 2011 09:17:09 -0500 Date: Tue, 27 Dec 2011 15:17:06 +0100 From: Michal Hocko To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, KAMEZAWA Hiroyuki , Balbir Singh , Johannes Weiner Subject: Re: [PATCH 5/6] memcg: fix broken boolen expression Message-ID: <20111227141706.GO5344@tiehlicka.suse.cz> References: <1324695619-5537-1-git-send-email-kirill@shutemov.name> <1324695619-5537-5-git-send-email-kirill@shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1324695619-5537-5-git-send-email-kirill@shutemov.name> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 24-12-11 05:00:18, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > action != CPU_DEAD || action != CPU_DEAD_FROZEN is always true. > > Signed-off-by: Kirill A. Shutemov Acked-by: Michal Hocko Thanks! > --- > mm/memcontrol.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index b27ce0f..3833a7b 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2100,7 +2100,7 @@ static int __cpuinit memcg_cpu_hotplug_callback(struct notifier_block *nb, > return NOTIFY_OK; > } > > - if ((action != CPU_DEAD) || action != CPU_DEAD_FROZEN) > + if (action != CPU_DEAD && action != CPU_DEAD_FROZEN) > return NOTIFY_OK; > > for_each_mem_cgroup(iter) > -- > 1.7.7.3 > -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic