From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754360Ab1L0O2i (ORCPT ); Tue, 27 Dec 2011 09:28:38 -0500 Received: from cantor2.suse.de ([195.135.220.15]:46591 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070Ab1L0O2h (ORCPT ); Tue, 27 Dec 2011 09:28:37 -0500 Date: Tue, 27 Dec 2011 15:28:34 +0100 From: Michal Hocko To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, KAMEZAWA Hiroyuki , Balbir Singh , Johannes Weiner Subject: Re: [PATCH 6/6] memcg: drop redundant brackets Message-ID: <20111227142834.GP5344@tiehlicka.suse.cz> References: <1324695619-5537-1-git-send-email-kirill@shutemov.name> <1324695619-5537-6-git-send-email-kirill@shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1324695619-5537-6-git-send-email-kirill@shutemov.name> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 24-12-11 05:00:19, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > Signed-off-by: Kirill A. Shutemov I wasn't very convinced at first but it makes some sense as we should be consistent. So Acked-by: Michal Hocko > --- > mm/memcontrol.c | 28 ++++++++++++++-------------- > 1 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 3833a7b..48cba05 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -73,7 +73,7 @@ static int really_do_swap_account __initdata = 0; > #endif > > #else > -#define do_swap_account (0) > +#define do_swap_account 0 > #endif > > > @@ -113,9 +113,9 @@ enum mem_cgroup_events_target { > MEM_CGROUP_TARGET_NUMAINFO, > MEM_CGROUP_NTARGETS, > }; > -#define THRESHOLDS_EVENTS_TARGET (128) > -#define SOFTLIMIT_EVENTS_TARGET (1024) > -#define NUMAINFO_EVENTS_TARGET (1024) > +#define THRESHOLDS_EVENTS_TARGET 128 > +#define SOFTLIMIT_EVENTS_TARGET 1024 > +#define NUMAINFO_EVENTS_TARGET 1024 > > struct mem_cgroup_stat_cpu { > long count[MEM_CGROUP_STAT_NSTATS]; > @@ -148,7 +148,7 @@ struct mem_cgroup_per_zone { > /* use container_of */ > }; > /* Macro for accessing counter */ > -#define MEM_CGROUP_ZSTAT(mz, idx) ((mz)->count[(idx)]) > +#define MEM_CGROUP_ZSTAT(mz, idx) ((mz)->count[idx]) > > struct mem_cgroup_per_node { > struct mem_cgroup_per_zone zoneinfo[MAX_NR_ZONES]; > @@ -346,8 +346,8 @@ static bool move_file(void) > * Maximum loops in mem_cgroup_hierarchical_reclaim(), used for soft > * limit reclaim to prevent infinite loops, if they ever occur. > */ > -#define MEM_CGROUP_MAX_RECLAIM_LOOPS (100) > -#define MEM_CGROUP_MAX_SOFT_LIMIT_RECLAIM_LOOPS (2) > +#define MEM_CGROUP_MAX_RECLAIM_LOOPS 100 > +#define MEM_CGROUP_MAX_SOFT_LIMIT_RECLAIM_LOOPS 2 > > enum charge_type { > MEM_CGROUP_CHARGE_TYPE_CACHE = 0, > @@ -368,11 +368,11 @@ enum mem_type { > _KMEM, > }; > > -#define MEMFILE_PRIVATE(x, val) (((x) << 16) | (val)) > -#define MEMFILE_TYPE(val) (((val) >> 16) & 0xffff) > +#define MEMFILE_PRIVATE(x, val) ((x) << 16 | (val)) > +#define MEMFILE_TYPE(val) ((val) >> 16 & 0xffff) > #define MEMFILE_ATTR(val) ((val) & 0xffff) > /* Used for OOM nofiier */ > -#define OOM_CONTROL (0) > +#define OOM_CONTROL 0 > > /* > * Reclaim flags for mem_cgroup_hierarchical_reclaim > @@ -1913,7 +1913,7 @@ struct memcg_stock_pcp { > unsigned int nr_pages; > struct work_struct work; > unsigned long flags; > -#define FLUSHING_CACHED_CHARGE (0) > +#define FLUSHING_CACHED_CHARGE 0 > }; > static DEFINE_PER_CPU(struct memcg_stock_pcp, memcg_stock); > static DEFINE_MUTEX(percpu_charge_mutex); > @@ -2094,7 +2094,7 @@ static int __cpuinit memcg_cpu_hotplug_callback(struct notifier_block *nb, > struct memcg_stock_pcp *stock; > struct mem_cgroup *iter; > > - if ((action == CPU_ONLINE)) { > + if (action == CPU_ONLINE) { > for_each_mem_cgroup(iter) > synchronize_mem_cgroup_on_move(iter, cpu); > return NOTIFY_OK; > @@ -2458,8 +2458,8 @@ static void __mem_cgroup_commit_charge(struct mem_cgroup *memcg, > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > > -#define PCGF_NOCOPY_AT_SPLIT ((1 << PCG_LOCK) | (1 << PCG_MOVE_LOCK) |\ > - (1 << PCG_MIGRATION)) > +#define PCGF_NOCOPY_AT_SPLIT (1 << PCG_LOCK | 1 << PCG_MOVE_LOCK |\ > + 1 << PCG_MIGRATION) > /* > * Because tail pages are not marked as "used", set it. We're under > * zone->lru_lock, 'splitting on pmd' and compound_lock. > -- > 1.7.7.3 > -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic