Hi Andrew, After merging the akpm tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: kernel/time/tick-sched.c:874:7: warning: 'struct sysdev_attribute' declared inside parameter list [enabled by default] kernel/time/tick-sched.c:874:7: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] kernel/time/tick-sched.c:874:7: warning: 'struct sys_device' declared inside parameter list [enabled by default] kernel/time/tick-sched.c: In function 'sysfs_store_do_timer_cpu': kernel/time/tick-sched.c:876:9: error: implicit declaration of function 'SYSDEV_TO_EXT_ATTR' [-Werror=implicit-function-declaration] kernel/time/tick-sched.c:876:36: warning: initialization makes pointer from integer without a cast [enabled by default] kernel/time/tick-sched.c:898:22: error: dereferencing pointer to incomplete type kernel/time/tick-sched.c: At top level: kernel/time/tick-sched.c:905:15: error: variable 'attr_jiffies_cpu' has initializer but incomplete type kernel/time/tick-sched.c:906:4: error: implicit declaration of function '_SYSDEV_ATTR' [-Werror=implicit-function-declaration] kernel/time/tick-sched.c:906:17: error: 'jiffies_cpu' undeclared here (not in a function) kernel/time/tick-sched.c:906:36: error: 'sysdev_show_int' undeclared here (not in a function) kernel/time/tick-sched.c:907:6: warning: excess elements in struct initializer [enabled by default] kernel/time/tick-sched.c:907:6: warning: (near initialization for 'attr_jiffies_cpu') [enabled by default] kernel/time/tick-sched.c:908:4: warning: excess elements in struct initializer [enabled by default] kernel/time/tick-sched.c:908:4: warning: (near initialization for 'attr_jiffies_cpu') [enabled by default] kernel/time/tick-sched.c:910:15: error: variable 'timekeeping_sysclass' has initializer but incomplete type kernel/time/tick-sched.c:911:2: error: unknown field 'name' specified in initializer kernel/time/tick-sched.c:911:2: warning: excess elements in struct initializer [enabled by default] kernel/time/tick-sched.c:911:2: warning: (near initialization for 'timekeeping_sysclass') [enabled by default] kernel/time/tick-sched.c:914:15: error: variable 'device_timekeeping' has initializer but incomplete type kernel/time/tick-sched.c:915:2: error: unknown field 'id' specified in initializer kernel/time/tick-sched.c:915:2: warning: excess elements in struct initializer [enabled by default] kernel/time/tick-sched.c:915:2: warning: (near initialization for 'device_timekeeping') [enabled by default] kernel/time/tick-sched.c:916:2: error: unknown field 'cls' specified in initializer kernel/time/tick-sched.c:916:2: warning: excess elements in struct initializer [enabled by default] kernel/time/tick-sched.c:916:2: warning: (near initialization for 'device_timekeeping') [enabled by default] kernel/time/tick-sched.c: In function 'init_timekeeping_sysfs': kernel/time/tick-sched.c:921:2: error: implicit declaration of function 'sysdev_class_register' [-Werror=implicit-function-declaration] kernel/time/tick-sched.c:924:3: error: implicit declaration of function 'sysdev_register' [-Werror=implicit-function-declaration] kernel/time/tick-sched.c:926:3: error: implicit declaration of function 'sysdev_create_file' [-Werror=implicit-function-declaration] kernel/time/tick-sched.c:928:5: error: invalid use of undefined type 'struct sysdev_ext_attribute' Caused by commit 629d589817da ("tick-sched: add specific do_timer_cpu value for nohz off mode") interacting with the removal of sysdevs in the driver-core tree. This patch will need reworking for that. I have reverted that commit for today. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/