From: David Miller <davem@davemloft.net>
To: rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org, sfr@canb.auug.org.au,
greg@kroah.com, kay.sievers@vrfy.org, akpm@linux-foundation.org,
fweisbec@gmail.com, mingo@redhat.com, linux-next@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] tracing/mm: Move include of trace/events/kmem.h out of header into slab.c
Date: Mon, 09 Jan 2012 14:21:04 -0800 (PST) [thread overview]
Message-ID: <20120109.142104.622129906887115582.davem@davemloft.net> (raw)
In-Reply-To: <1326147342.7642.41.camel@gandalf.stny.rr.com>
From: Steven Rostedt <rostedt@goodmis.org>
Date: Mon, 09 Jan 2012 17:15:42 -0500
> Including trace/events/*.h TRACE_EVENT() macro headers in other headers
> can cause strange side effects if another trace/event/*.h header
> includes that header. Having trace/events/kmem.h inside slab_def.h
> caused a compile error in sparc64 when changes were done to some header
> files. Moving the kmem.h trace header out of slab.h and into slab.c
> fixes the problem.
>
> Note, both slub.c and slob.c already include the trace/events/kmem.h
> file. Only slab.c had it missing.
>
> Link: http://lkml.kernel.org/r/20120105190405.1e3191fb5a43b2a0f1655e1f@canb.auug.org.au
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Acked-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2012-01-09 22:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 22:15 [PATCH] tracing/mm: Move include of trace/events/kmem.h out of header into slab.c Steven Rostedt
2012-01-09 22:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109.142104.622129906887115582.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).