From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755280Ab2AIB6X (ORCPT ); Sun, 8 Jan 2012 20:58:23 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:46078 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755223Ab2AIB6W (ORCPT ); Sun, 8 Jan 2012 20:58:22 -0500 Date: Mon, 9 Jan 2012 10:08:51 +0800 From: Shawn Guo To: Richard Zhao Cc: Dong Aisheng , linux-kernel@vger.kernel.org, linus.walleij@stericsson.com, s.hauer@pengutronix.de, w.sang@pengutronix.de, rob.herring@calxeda.com, grant.likely@secretlab.ca, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, cjb@laptop.org, devicetree-discuss@lists.ozlabs.org, shawn.guo@freescale.com Subject: Re: [RFC PATCH v3 3/5] pinctrl: imx: add pinctrl imx driver Message-ID: <20120109020848.GF1835@S2101-09.ap.freescale.net> References: <1324402840-32451-1-git-send-email-b29396@freescale.com> <1324402840-32451-4-git-send-email-b29396@freescale.com> <20120108130542.GC2203@richard-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120108130542.GC2203@richard-laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 08, 2012 at 09:05:44PM +0800, Richard Zhao wrote: > > +enum imx_imx53_pinctrl_pads { > > + MX53_GPIO_19 = 0, > > + MX53_KEY_COL0 = 1, > > + MX53_KEY_ROW0 = 2, > > + MX53_KEY_COL1 = 3, > > + MX53_KEY_ROW1 = 4, > > + MX53_KEY_COL2 = 5, > > + MX53_KEY_ROW2 = 6, > ... > Why not describe it in dts and make this file generic for imx? > One node for one pad, Doing this will bloat the device tree dramatically. Actually I had a patch doing so before the pinctrl subsystem was born, but it concerned Grant a lot for that reason and thus died. > it'll be easy to extend pad properties. You know > the pad may set pull up/down, open drain, drive strenth, daisy chain etc. > The features have to be supported, to make your model usefull. > As Aisheng mentioned, the pinconf support will be added later. -- Regards, Shawn