linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: btrfs/mmap lockdep report from 3.2
Date: Mon, 9 Jan 2012 20:44:32 -0500	[thread overview]
Message-ID: <20120110014432.GC26546@shiny> (raw)
In-Reply-To: <20120110010331.GA15942@redhat.com>

On Mon, Jan 09, 2012 at 08:03:32PM -0500, Dave Jones wrote:
> Just hit this with Linus' tree as of 37cfc3f67db9f2d907f6bfcfae590cdbbef623e8
> 
> 	Dave
> 
> [  130.932837] ======================================================
> [  130.933032] [ INFO: possible circular locking dependency detected ]
> [  130.933032] 3.2.0+ #19 Not tainted
> [  130.933032] -------------------------------------------------------
> [  130.933032] firefox/1630 is trying to acquire lock:
> [  130.933032]  (&sb->s_type->i_mutex_key#13){+.+.+.}, at: [<ffffffffa011fd5b>] btrfs_page_mkwrite+0x5b/0x310 [btrfs]
> [  130.933032] 
> [  130.933032] but task is already holding lock:
> [  130.933032]  (&mm->mmap_sem){++++++}, at: [<ffffffff816a38c8>] do_page_fault+0xe8/0x5d0
> [  130.933032] 
> [  130.933032] which lock already depends on the new lock.

>From a lockdep point of view, this is real.  But the page_mkwrite
code is never called on directories so it is actually safe.  We'll fix
it up.

-chris

  reply	other threads:[~2012-01-10  1:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-10  1:03 btrfs/mmap lockdep report from 3.2 Dave Jones
2012-01-10  1:44 ` Chris Mason [this message]
2012-01-17 23:25   ` Jan Kara
2012-01-18  1:06     ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120110014432.GC26546@shiny \
    --to=chris.mason@oracle.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).