From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756536Ab2AJSEd (ORCPT ); Tue, 10 Jan 2012 13:04:33 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:59442 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752303Ab2AJSEb (ORCPT ); Tue, 10 Jan 2012 13:04:31 -0500 Date: Tue, 10 Jan 2012 18:04:21 +0000 From: Al Viro To: Miklos Szeredi Cc: Linus Torvalds , Dave Chinner , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, mgorman@suse.de, gregkh@suse.de, akpm@linux-foundation.org Subject: Re: [RFC PATCH] shrink_dcache_parent() deadlock Message-ID: <20120110180421.GC23916@ZenIV.linux.org.uk> References: <20120109171639.GA9359@infradead.org> <20120109173010.GX23916@ZenIV.linux.org.uk> <20120109205907.GE4198@dastard> <20120110013434.GA23916@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 10, 2012 at 05:22:22PM +0100, Miklos Szeredi wrote: > I think prune_dcache_sb() doesn't need this logic (although it > wouldn't hurt either) because that one is called from the slab > shrinkers and those are protected from being run multiple times in > parallel, I hope. Eh... We already have too much convoluted logics in there, so let's keep it as non-subtle as possible.