From: Greg KH <greg@kroah.com>
To: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Jiang Liu <liuj97@gmail.com>,
linux-kernel@vger.kernel.org,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Jim Keniston <jkenisto@us.ibm.com>,
Jun Ma <harry.majun@huawei.com>,
stable@vger.kernel.org, Jiang Liu <jiang.liu@huawei.com>
Subject: Re: [PATCH] kprobes: fix a memory leak in function pre_handler_kretprobe()
Date: Wed, 11 Jan 2012 08:59:10 -0800 [thread overview]
Message-ID: <20120111165910.GB2794@kroah.com> (raw)
In-Reply-To: <20120111161233.GA13539@in.ibm.com>
On Wed, Jan 11, 2012 at 09:42:33PM +0530, Ananth N Mavinakayanahalli wrote:
> On Wed, Jan 11, 2012 at 11:21:51PM +0800, Jiang Liu wrote:
> > From: Jiang Liu <liuj97@gmail.com>
> >
> > In function pre_handler_kretprobe(), the allocated kretprobe_instance object
> > will be leaked if the entry_handler callback returns non-zero. This may cause
> > all the preallocated kretprobe_instance objects exhausted. This issue could be
> > reproduced by changing samples/kprobes/kretprobe_example.c to probe
> > "mutex_unlock". And the fix is straight forward, just put the allocated
> > kretprobe_instance object back onto the free_instances list.
> >
> > Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
> > Acked-by: Jim Keniston <jkenisto@us.ibm.com>
> > Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>
> Thank you Jiang. I think the correct ID for stable is now
> stable@vger.kernel.org.
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2012-01-11 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 15:21 [PATCH] kprobes: fix a memory leak in function pre_handler_kretprobe() Jiang Liu
2012-01-11 16:12 ` Ananth N Mavinakayanahalli
2012-01-11 16:59 ` Greg KH [this message]
2012-01-30 16:10 Jiang Liu
2012-01-31 21:35 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111165910.GB2794@kroah.com \
--to=greg@kroah.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=harry.majun@huawei.com \
--cc=jiang.liu@huawei.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).