From: Johan Hedberg <johan.hedberg@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Gustavo F. Padovan" <padovan@profusion.mobi>,
Marcel Holtmann <marcel@holtmann.org>,
"David S. Miller" <davem@davemloft.net>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blutetooth: Remove bogus inline for l2cap_chan_connect()
Date: Sun, 15 Jan 2012 12:52:03 +0200 [thread overview]
Message-ID: <20120115105203.GA12584@x220.P-661HNU-F1> (raw)
In-Reply-To: <1326622076-957-1-git-send-email-geert@linux-m68k.org>
Hi Geert,
On Sun, Jan 15, 2012, Geert Uytterhoeven wrote:
> commit 03a001948166d966d0d580cddb8ae3a23f8b795b ("Bluetooth: invert locking
> order in connect path") marked l2cap_chan_connect() inline for both the
> prototype in include/net/bluetooth/l2cap.h and the implementation in
> net/bluetooth/l2cap_core.c.
>
> As the former doesn't contain an implementation, net/bluetooth/l2cap_sock.c
> now fails to build, e.g. for m68k allmodconfig:
>
> net/bluetooth/l2cap_sock.c: In function ‘l2cap_sock_connect’:
> include/net/bluetooth/l2cap.h:838: sorry, unimplemented: inlining failed in call to ‘l2cap_chan_connect’: function body not available
> net/bluetooth/l2cap_sock.c:126: sorry, unimplemented: called from here
> make[1]: *** [net/bluetooth/l2cap_sock.o] Error 1
>
> As l2cap_chan_connect() is not that small and also called from
> net/bluetooth/l2cap_sock.c, I removed both inline keywords.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> --
> As I can't seem to find anyone else getting this, I guess it's only
> triggered by some versions of gcc. Mine is
>
> gcc version 4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21)
> ---
> include/net/bluetooth/l2cap.h | 2 +-
> net/bluetooth/l2cap_core.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
This was already reported[1] earlier this month and a patch[2] was also
created for it which right now resides in my bluetooth-next tree[3].
Johan
[1] http://www.spinics.net/lists/linux-bluetooth/msg19851.html
[2] http://www.spinics.net/lists/linux-bluetooth/msg20009.html
[3] http://git.kernel.org/?p=linux/kernel/git/jh/bluetooth-next.git;a=commitdiff;h=cd555072d0b0738c8a107776fe91902da686f94d
next prev parent reply other threads:[~2012-01-15 10:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 10:07 [PATCH] blutetooth: Remove bogus inline for l2cap_chan_connect() Geert Uytterhoeven
2012-01-15 10:52 ` Johan Hedberg [this message]
2012-01-15 11:25 ` Geert Uytterhoeven
2012-02-06 10:41 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120115105203.GA12584@x220.P-661HNU-F1 \
--to=johan.hedberg@gmail.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).