From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Sergei Trofimovich <slyich@gmail.com>,
linux-kernel@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>,
Linux PM mailing list <linux-pm@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
Tony Luck <tony.luck@intel.com>, "mingo@elte.hu" <mingo@elte.hu>,
Borislav Petkov <bp@amd64.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
prasad@linux.vnet.ibm.com
Subject: Re: 3.2.0-07927-gc49c41a: s2ram: Device 'machinecheck1' does not have a release() function, it is broken and must be fixed
Date: Mon, 16 Jan 2012 23:08:49 +0100 [thread overview]
Message-ID: <201201162308.49530.rjw@sisk.pl> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1201161645490.11125-100000@netrider.rowland.org>
On Monday, January 16, 2012, Alan Stern wrote:
> On Mon, 16 Jan 2012, Rafael J. Wysocki wrote:
>
> > On Monday, January 16, 2012, Srivatsa S. Bhat wrote:
>
> > > Just to re-instate, an end-user need not really worry about this warning
> > > too much since this was there before (at a different place, and hidden)
> > > when things were working fine... Hence it would be worthwhile to fix
> > > this warning "correctly" if possible, than just do a quick and dirty
> > > "silence the warning" kind of workaround.
> >
> > Well, since there's nothing to release in there, I really see only two
> > possible "fixes": either silence the warning the way you describe, or
> > remove it from the core.
>
> No, the right fix is to release something. The device structures
> should be allocated dynamically, not statically. Greg's suggestion of
> using a set of per-cpu pointers to dynamically-allocated structures
> sounds right.
OK, so the source of the problem is that the device structure is statically
allocated, right?
Rafael
next prev parent reply other threads:[~2012-01-16 22:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120116131842.53f7ccc8@sf.home>
2012-01-16 11:22 ` 3.2.0-07927-gc49c41a: s2ram: Device 'machinecheck1' does not have a release() function, it is broken and must be fixed Srivatsa S. Bhat
2012-01-16 11:37 ` Sergei Trofimovich
2012-01-16 20:48 ` Rafael J. Wysocki
2012-01-16 21:49 ` Alan Stern
2012-01-16 22:08 ` Rafael J. Wysocki [this message]
2012-01-16 22:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201162308.49530.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=bp@amd64.org \
--cc=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=prasad@linux.vnet.ibm.com \
--cc=slyich@gmail.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).