From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757875Ab2ARPCH (ORCPT ); Wed, 18 Jan 2012 10:02:07 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36091 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757852Ab2ARPCF (ORCPT ); Wed, 18 Jan 2012 10:02:05 -0500 Date: Wed, 18 Jan 2012 07:00:07 -0800 From: Greg KH To: Konrad Rzeszutek Wilk Cc: Pekka Enberg , Leonid Moiseichuk , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cesarb@cesarb.net, kamezawa.hiroyu@jp.fujitsu.com, emunson@mgebm.net, aarcange@redhat.com, riel@redhat.com, mel@csn.ul.ie, rientjes@google.com, dima@android.com, rebecca@android.com, san@google.com, akpm@linux-foundation.org, vesa.jaaskelainen@nokia.com Subject: Re: [PATCH v2 1/2] Making si_swapinfo exportable Message-ID: <20120118150007.GA18315@suse.de> References: <56cc3c5d40a8653b7d9bef856ff02d909b98f36f.1326803859.git.leonid.moiseichuk@nokia.com> <20120118140904.GB13817@suse.de> <20120118144618.GA7438@phenom.dumpdata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120118144618.GA7438@phenom.dumpdata.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2012 at 09:46:18AM -0500, Konrad Rzeszutek Wilk wrote: > > > > +EXPORT_SYMBOL(si_swapinfo); > > > > EXPORT_SYMBOL_GPL() perhaps? > > Greg, > > So.. could you tell when are suppose to do _GPL and when not? Is there > a policy of "new code must be _GPL" ? Or is there some extra "if .. then" > conditions? It's up to the author of the code, what their preference is. I just generally prefer _GPL for new exports. thanks, greg k-h