From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932595Ab2ASQb5 (ORCPT ); Thu, 19 Jan 2012 11:31:57 -0500 Received: from fieldses.org ([174.143.236.118]:54306 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932290Ab2ASQbw (ORCPT ); Thu, 19 Jan 2012 11:31:52 -0500 Date: Thu, 19 Jan 2012 11:31:49 -0500 From: "J. Bruce Fields" To: Stanislav Kinsbursky Cc: Trond.Myklebust@netapp.com, linux-nfs@vger.kernel.org, xemul@parallels.com, neilb@suse.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jbottomley@parallels.com, davem@davemloft.net, devel@openvz.org Subject: Re: [PATCH 3/5] SUNRPC: create GSS auth cache per network namespace Message-ID: <20120119163149.GD527@fieldses.org> References: <20120119144517.9957.59143.stgit@localhost6.localdomain6> <20120119144922.9957.39352.stgit@localhost6.localdomain6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120119144922.9957.39352.stgit@localhost6.localdomain6> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2012 at 06:49:23PM +0400, Stanislav Kinsbursky wrote: > @@ -1000,6 +996,7 @@ static int svcauth_gss_handle_init(struct svc_rqst *rqstp, > struct xdr_netobj tmpobj; > struct rsi *rsip, rsikey; > int ret; > + struct sunrpc_net *sn = net_generic(rqstp->rq_xprt->xpt_net, sunrpc_net_id); OK, so you're getting the network namespace out of the rqstp, and, then passing it down, makes sense. And: > @@ -1079,6 +1076,7 @@ svcauth_gss_accept(struct svc_rqst *rqstp, __be32 *authp) > __be32 *rpcstart; > __be32 *reject_stat = resv->iov_base + resv->iov_len; > int ret; > + struct sunrpc_net *sn = net_generic(rqstp->rq_xprt->xpt_net, sunrpc_net_id); ... same for the gss cache. Looks good. How do you plan to test this? --b.