From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
"Ohad Ben-Cohen" <ohad@wizery.com>,
David Woodhouse <dwmw2@infradead.org>,
David Brown <davidb@codeaurora.org>,
Tony Lindgren <tony@atomide.com>, Stuart Yoder <b08248@gmail.com>,
Scott Wood <scottwood@freescale.com>,
Hiroshi Doyu <hdoyu@nvidia.com>
Subject: Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute
Date: Thu, 19 Jan 2012 17:27:09 +0100 [thread overview]
Message-ID: <201201191727.10176.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20120119160739.GB2205@amd.com>
Hi Joerg,
On Thursday 19 January 2012 17:07:39 Joerg Roedel wrote:
> On Thu, Jan 19, 2012 at 04:46:13PM +0100, Laurent Pinchart wrote:
> > > +struct iommu_domain_geometry {
> > > + u64 aperture_start; /* First address that can be mapped */
> > > + u64 aperture_end; /* Last address that can be mapped */
> >
> > Would it make sense to use a platform-dependent type that represents
> > physical addresses instead of u64 ?
>
> Well, u64 is a catch-all datatype which should suit all drivers. Is this
> a problem at ARM?
No, it's not a problem for ARM, at least to my knowledge. It just struck me as
weird, as we have specific data types for other kinds of addresses (such as
dma_addr_t).
> We can also go the more complicated way of introducing an iova_addr_t or
> something. But if possible I would like to avoid that.
>
> > > @@ -62,7 +70,8 @@ enum iommu_attr {
> > >
> > > * @unmap: unmap a physically contiguous memory region from an iommu
> > >
> > > domain * @iova_to_phys: translate iova to physical address
> > >
> > > * @domain_has_cap: domain capabilities query
> > >
> > > - * @commit: commit iommu domain
> > > + * @domain_get_attr: Query domain attributes
> > > + * @domain_set_attr: Change domain attributes
> >
> > This belongs to the previous patch.
>
> Right, I change that.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-01-19 16:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 14:30 [PATCH 0/5] IOMMU: Make IOMMU-API ready for GART-like hardware Joerg Roedel
2012-01-19 14:30 ` [PATCH 1/5] iommu: Add domain-attribute handlers Joerg Roedel
2012-01-19 14:30 ` [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute Joerg Roedel
2012-01-19 15:46 ` Laurent Pinchart
2012-01-19 16:07 ` Joerg Roedel
2012-01-19 16:27 ` Laurent Pinchart [this message]
2012-01-20 5:44 ` Hiroshi Doyu
2012-01-20 16:01 ` Joerg Roedel
2012-02-01 9:37 ` Sethi Varun-B16395
2012-01-26 18:26 ` Scott Wood
2012-01-19 17:16 ` Sethi Varun-B16395
2012-01-20 16:03 ` Joerg Roedel
2012-01-26 18:25 ` Scott Wood
2012-01-26 18:31 ` Joerg Roedel
2012-01-26 18:42 ` Scott Wood
2012-01-26 18:51 ` Joerg Roedel
2012-01-26 19:00 ` Scott Wood
2012-01-26 19:44 ` Joerg Roedel
2012-01-26 20:02 ` Scott Wood
2012-01-27 11:01 ` Joerg Roedel
2012-01-27 21:22 ` Scott Wood
2012-01-30 14:24 ` Joerg Roedel
2012-01-30 20:21 ` Scott Wood
2012-01-30 6:27 ` Sethi Varun-B16395
2012-01-30 14:30 ` Joerg Roedel
2012-01-19 14:30 ` [PATCH 3/5] iommu/vt-d: " Joerg Roedel
2012-01-19 14:30 ` [PATCH 4/5] iommu/omap: " Joerg Roedel
2012-01-19 14:30 ` [PATCH 5/5] iommu/msm: " Joerg Roedel
2012-01-20 6:14 ` [PATCH 0/5] IOMMU: Make IOMMU-API ready for GART-like hardware Hiroshi Doyu
2012-01-20 16:05 ` joerg.roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201191727.10176.laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=b08248@gmail.com \
--cc=davidb@codeaurora.org \
--cc=dwmw2@infradead.org \
--cc=hdoyu@nvidia.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=scottwood@freescale.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).