From: Daniel Vetter <daniel@ffwll.ch>
To: Robert Morell <rmorell@nvidia.com>
Cc: "Semwal, Sumit" <sumit.semwal@ti.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"sumit.semwal@linaro.org" <sumit.semwal@linaro.org>
Subject: Re: [PATCH] dma-buf: Use EXPORT_SYMBOL
Date: Sat, 21 Jan 2012 18:32:07 +0100 [thread overview]
Message-ID: <20120121173207.GF3821@phenom.ffwll.local> (raw)
In-Reply-To: <20120120180457.GE29824@morell.nvidia.com>
On Fri, Jan 20, 2012 at 10:04:57AM -0800, Robert Morell wrote:
> On Wed, Jan 18, 2012 at 01:10:04AM -0800, Semwal, Sumit wrote:
> > On Wed, Jan 18, 2012 at 5:38 AM, Robert Morell <rmorell@nvidia.com> wrote:
> > > EXPORT_SYMBOL_GPL is intended to be used for "an internal implementation
> > > issue, and not really an interface". The dma-buf infrastructure is
> > > explicitly intended as an interface between modules/drivers, so it
> > > should use EXPORT_SYMBOL instead.
> >
> > + Konrad, Arnd, Mauro: there were strong objections on using
> > EXPORT_SYMBOL in place of EXPORT_SYMBOL_GPL by all 3 of them; I
> > suggest we first arrive at a consensus before merging this patch.
>
> This discussion seems to have stagnated; how do we move forward here?
>
> Sumit, as the primary author and new maintainer (congrats!) of the
> dma-buf infrastructure, it seems like it's really your call how to
> proceed. I'd still like to see this be something that we can use from
> the nvidia and fglrx drivers for Xorg buffer sharing, as I and Dave have
> argued in this thread. It really seems to me that this change on a
> technical level won't have any adverse effect on the scenarios where it
> can be used today, but it will allow it to be used more widely, which
> will prevent duplication and fragmentation in the future and be greatly
> appreciated by users of hardware such as Optimus.
Given that I've participated quite a bit in the design of dma_buf as-is,
let me throw in my totally irrelevant opinion, too ;-)
I'll refrain from comment on the actual patch, it's obviously a hot topic.
Furthermore I might need to ask Intel's legal dep for guidance to asses
things wrt my own contributions to dma_buf.
Otoh I'd like nvidia to be on board, especially when we're desingned
additions to dma_buf required to make it really work for multiple gpus. In
additions it looks like that the nvidia blob will only be an importer of a
dma_buf, at least for the use-cases discussed here.
So why don't you just ditch this patch here and add a small shim to your
blob to interface with drm's prime as an importing driver? I personally
would deem that acceptable and I think Dave wouldn't mind too much,
either.
Yours, Daniel
Disclaimer: This is my own opinion and I do not speak as an Intel employee
here.
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-01-21 17:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.00.1201061458020.18430@skynet.skynet.ie>
2012-01-18 0:08 ` Expanding the use of DMA buffers in 3.3 Robert Morell
2012-01-18 0:08 ` [PATCH] dma-buf: Use EXPORT_SYMBOL Robert Morell
2012-01-18 9:10 ` Semwal, Sumit
2012-01-18 12:14 ` Arnd Bergmann
2012-01-18 12:21 ` Dave Airlie
2012-01-18 13:55 ` Ilija Hadzic
2012-01-18 14:00 ` Dave Airlie
2012-01-19 1:11 ` Robert Morell
2012-01-18 14:39 ` Arnd Bergmann
2012-01-18 12:23 ` Mauro Carvalho Chehab
2012-01-19 7:26 ` Dave Airlie
2012-01-20 18:04 ` Robert Morell
2012-01-20 18:12 ` Konrad Rzeszutek Wilk
2012-01-21 17:32 ` Daniel Vetter [this message]
2012-01-25 5:34 ` Semwal, Sumit
2012-01-25 12:30 ` Alan Cox
2012-01-25 13:46 ` Mauro Carvalho Chehab
2012-01-25 13:48 ` Mauro Carvalho Chehab
2012-01-18 11:48 ` Alan Cox
2012-02-19 21:20 ` Rob Clark
2012-01-18 11:53 ` Expanding the use of DMA buffers in 3.3 Alan Cox
2012-01-19 6:43 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120121173207.GF3821@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=rmorell@nvidia.com \
--cc=sumit.semwal@linaro.org \
--cc=sumit.semwal@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).