From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] virtio: correct the memory barrier in virtqueue_kick_prepare()
Date: Sun, 22 Jan 2012 13:47:57 +0200 [thread overview]
Message-ID: <20120122114757.GD27222@redhat.com> (raw)
In-Reply-To: <20120120081708.50747.60241.stgit@amd-6168-8-1.englab.nay.redhat.com>
On Fri, Jan 20, 2012 at 04:17:08PM +0800, Jason Wang wrote:
> Use virtio_mb() to make sure the available index to be exposed before
> checking the the avail event. Otherwise we may get stale value of
> avail event in guest and never kick the host after.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Good catch.
Note: this fixes a bug introduced by ee7cd8981e15bcb365fc762afe3fc47b8242f630.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/virtio/virtio_ring.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 78428a8..07d9360 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -308,9 +308,9 @@ bool virtqueue_kick_prepare(struct virtqueue *_vq)
> bool needs_kick;
>
> START_USE(vq);
> - /* Descriptors and available array need to be set before we expose the
> - * new available array entries. */
> - virtio_wmb(vq);
> + /* We need expose available array entries before checking avail
Nit:
We need expose -> Need to expose
> + * event. */
> + virtio_mb(vq);
>
> old = vq->vring.avail->idx - vq->num_added;
> new = vq->vring.avail->idx;
next prev parent reply other threads:[~2012-01-22 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 8:16 [PATCH 1/2] virtio: fix typos of memory barriers Jason Wang
2012-01-20 8:17 ` [PATCH 2/2] virtio: correct the memory barrier in virtqueue_kick_prepare() Jason Wang
2012-01-22 11:47 ` Michael S. Tsirkin [this message]
2012-01-22 23:34 ` Rusty Russell
2012-01-22 11:47 ` [PATCH 1/2] virtio: fix typos of memory barriers Michael S. Tsirkin
2012-01-22 23:07 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120122114757.GD27222@redhat.com \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).