linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Neukum <oliver@neukum.org>
To: ondra.havel@gmail.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] input: Hanvon Art Master I and Rollick tablet support (USB)
Date: Tue, 24 Jan 2012 13:41:10 +0100	[thread overview]
Message-ID: <201201241341.10614.oliver@neukum.org> (raw)
In-Reply-To: <alpine.LRH.2.00.1201230211440.12906@linux.fjfi.cvut.cz>

Am Montag, 23. Januar 2012, 02:22:07 schrieb ondra.havel@gmail.com:
> +static void hanvon_disconnect(struct usb_interface *intf)
> +{
> +       struct hanvon *hanvon = usb_get_intfdata(intf);
> +
> +       usb_set_intfdata(intf, NULL);
> +       usb_kill_urb(hanvon->irq);

What happens if there's a call to open() here?

> +       input_unregister_device(hanvon->dev);
> +       usb_free_urb(hanvon->irq);
> +       usb_free_coherent(interface_to_usbdev(intf), USB_AM_PACKET_LEN, hanvon->data, hanvon->data_dma);
> +       kfree(hanvon);
> +}
> +

	Regards
		Oliver

  reply	other threads:[~2012-01-24 12:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-23  1:22 [PATCH v2] input: Hanvon Art Master I and Rollick tablet support (USB) ondra.havel
2012-01-24 12:41 ` Oliver Neukum [this message]
2012-01-29  6:38 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201241341.10614.oliver@neukum.org \
    --to=oliver@neukum.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ondra.havel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).