From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756879Ab2AXRPt (ORCPT ); Tue, 24 Jan 2012 12:15:49 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:56250 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753393Ab2AXRPs (ORCPT ); Tue, 24 Jan 2012 12:15:48 -0500 Date: Tue, 24 Jan 2012 18:15:46 +0100 From: Pavel Machek To: Alan Cox Cc: "Torne (Richard Coles)" , nic_swsd@realtek.com, romieu@fr.zoreil.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] r8169: Randomise invalid MAC addresses Message-ID: <20120124171546.GA32184@atrey.karlin.mff.cuni.cz> References: <1327343540-30348-1-git-send-email-torne@google.com> <20120123212914.747c852f@pyramind.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120123212914.747c852f@pyramind.ukuu.org.uk> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > If the default MAC address stored in the card is invalid, replace it > > with a random address and complain about it. > > See the discussion about the pch ethernet card. Detect the error and warn > about it, block opening it and let the user set it with ifconfig xx hw > aa:bb:cc:dd:ee:ff Kernel should provide hw abstraction, and that should mean doing something about commonly-bad ethernet cards. Userspace does not quite cut it, think about nfsroot for example. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html