From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752598Ab2AZAJB (ORCPT ); Wed, 25 Jan 2012 19:09:01 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:46977 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919Ab2AZAI7 (ORCPT ); Wed, 25 Jan 2012 19:08:59 -0500 X-Sasl-enc: N3G8Le4Jq7Q8jLJv7chm4HE5ExvX2KHmFuiWIu+P9L8W 1327536538 Date: Wed, 25 Jan 2012 16:07:49 -0800 From: Greg KH To: Josh Boyer Cc: Sven-Haegar Koch , Paolo Bonzini , linux-kernel@vger.kernel.org, stable@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, linux-scsi@vger.kernel.org, Jens Axboe , James Bottomley Subject: Re: [v2] Re: [091/129] block: fail SCSI passthrough ioctls on partition devices Message-ID: <20120126000749.GC14281@kroah.com> References: <20120124023932.023409422@clark.kroah.org> <1327423431-13965-1-git-send-email-pbonzini@redhat.com> <20120125223937.GA12516@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 25, 2012 at 06:10:47PM -0500, Josh Boyer wrote: > On Wed, Jan 25, 2012 at 5:51 PM, Sven-Haegar Koch wrote: > > On Wed, 25 Jan 2012, Greg KH wrote: > > > >> On Tue, Jan 24, 2012 at 05:43:50PM +0100, Paolo Bonzini wrote: > >> > > You need to return -ENOTTY from scsi_verify_blk_ioctl and -ENOIOCTLCMD from > >> > > sd_compat_ioctl, because -ENOIOCTLCMD will not be handled correctly by > >> > > block/ioctl.c.  This would break BLKROSET and BLKFLSBUF done by non-root > >> > > but with the appropriate capabilities. > >> > > > >> > > Fixed patch follows.  If you prefer that I send an interdiff, let me know. > >> > >> Wait, why do you want the stable trees to diverge from what is in > >> Linus's tree with regards to the error codes being returned? > >> > >> That doesn't seem safe, or sane. > >> > >> So for now, I'm going to follow what is in Linus's tree.  If you > >> need/want the error codes to be different, then shouldn't it also be > >> done there as well? > > > > May be because the stable trees do not have > > 07d106d0a33d6063d2061305903deb02489eba20? "vfs: fix up ENOIOCTLCMD error > > handling"? > > I believe that is the case, yes. Linus was unhappy about ENOIOCTLCMD vs. > ENOTTY overall when the patch was first submitted, which lead to that commit. > The patches Paolo submitted for stable are the original versions that apply > directly to 3.2 and older. > > 07d106d0a isn't really stable material as it was put into 3.3 to catch any odd > fallout from the change. Ok, thanks both of you, that makes more sense now. I'll take Paolo's updated patches and do a release now. greg k-h