From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Semwal, Sumit" <sumit.semwal@ti.com>
Cc: linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
arnd@arndb.de, airlied@redhat.com, linux@arm.linux.org.uk,
patches@linaro.org, jesse.barker@linaro.org, daniel@ffwll.ch
Subject: Re: [Linaro-mm-sig] [PATCH 1/3] dma-buf: Introduce dma buffer sharing mechanism
Date: Thu, 26 Jan 2012 10:58:25 +0100 [thread overview]
Message-ID: <201201261058.27098.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <CAB2ybb98BT8L569G_728x1ZXdFNaQCDZzW2+kB0ZNeFak5_g+Q@mail.gmail.com>
Hi Sumit,
On Wednesday 25 January 2012 14:56:52 Semwal, Sumit wrote:
> On Fri, Jan 20, 2012 at 6:53 PM, Laurent Pinchart wrote:
> > Hi Summit,
> >
> > Sorry for the late review. I know that this code is now in mainline, but
> > I still have a couple of comments. I'll send patches if you agree with
> > them.
>
> Hi Laurent,
>
> Thanks for your review; apologies for being late in replying - I was
> OoO for last couple of days.
No worries.
[snip]
> Let me know if you'd send patches for these, or should I just go ahead and
> correct.
I'll send patches.
Another small comment. The map_dma_buf operation is defined as
struct sg_table * (*map_dma_buf)(struct dma_buf_attachment *,
enum dma_data_direction);
If we want to let exporters cache the sg_table we should return a const struct
sg_table *. unmap_dma_buf will then take a const pointer as well, which would
need to be cast to a non-const pointer internally. What's your opinion on that
?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-01-26 9:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 9:23 [PATCH 0/3] Introduce DMA buffer sharing mechanism Sumit Semwal
2011-12-26 9:23 ` [PATCH 1/3] dma-buf: Introduce dma " Sumit Semwal
2011-12-28 2:27 ` InKi Dae
2012-01-20 13:23 ` [Linaro-mm-sig] " Laurent Pinchart
2012-01-25 13:56 ` Semwal, Sumit
2012-01-26 9:58 ` Laurent Pinchart [this message]
2012-01-25 17:02 ` Tomasz Stanislawski
2012-01-25 20:07 ` Daniel Vetter
2012-01-26 5:35 ` Semwal, Sumit
2011-12-26 9:23 ` [PATCH 2/3] dma-buf: Documentation for buffer sharing framework Sumit Semwal
2012-01-01 20:09 ` Sakari Ailus
2012-01-01 23:02 ` Rob Clark
2011-12-26 9:23 ` [PATCH 3/3] dma-buf: mark EXPERIMENTAL for 1st release Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201261058.27098.laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@redhat.com \
--cc=arnd@arndb.de \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesse.barker@linaro.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
--cc=sumit.semwal@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).