From: Tejun Heo <tj@kernel.org>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
dm-devel@redhat.com
Subject: Re: [PATCH] block: add missing block_bio_complete() tracepoint
Date: Sun, 29 Jan 2012 18:30:12 -0800 [thread overview]
Message-ID: <20120130023012.GH17211@htj.dyndns.org> (raw)
In-Reply-To: <4F25FEE5.5010309@gmail.com>
On Mon, Jan 30, 2012 at 11:22:29AM +0900, Namhyung Kim wrote:
> >It's just that this patch as it stands will break the existing tools
> >and is likely to cause some amount of head scratching for blktrace
> >users upgrading to new kernel with existing userland, so yeah, I think
> >it should be filtered in kernel from blktrace.c.
>
> Will it break blktrace? Looking at the code, not tested though, it
> will just add one more 'C' line for bounced bio, and that's it? The
> blktrace will get way more 'C' lines for normal request based
> devices and it needs to be handled anyway. Am I missing something?
Hmmm... maybe I'm confused. Wouldn't it cause duplicate completions
for all rq based drivers too?
--
tejun
next prev parent reply other threads:[~2012-01-30 2:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 9:41 [PATCH] block: add missing block_bio_complete() tracepoint Namhyung Kim
2012-01-29 19:24 ` Tejun Heo
2012-01-30 1:44 ` Namhyung Kim
2012-01-30 1:47 ` Tejun Heo
2012-01-30 2:22 ` Namhyung Kim
2012-01-30 2:30 ` Tejun Heo [this message]
2012-01-30 2:49 ` Namhyung Kim
2012-01-30 2:53 ` Tejun Heo
2012-01-30 5:51 ` Namhyung Kim
2012-01-30 5:54 ` Tejun Heo
2012-01-30 6:02 ` Namhyung Kim
2012-01-30 6:38 ` Namhyung Kim
2012-01-30 17:05 ` Tejun Heo
2012-01-31 6:30 ` Namhyung Kim
2012-01-31 10:39 ` Tejun Heo
2012-02-01 2:18 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130023012.GH17211@htj.dyndns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).