From: Andrea Shepard <andrea@persephoneslair.org>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: khc@pm.waw.pl, davem@davemloft.net, mmarek@suse.cz,
jkosina@suse.cz, joe@perches.com, justinmattock@gmail.com,
gregkh@suse.de, alan@linux.intel.com, jdmason@kudzu.us
Subject: [09/22] Cyclades PC300 driver: use kzalloc() so we don't have to memset()
Date: Sun, 29 Jan 2012 18:50:50 -0800 [thread overview]
Message-ID: <20120130025050.GJ10262@cronus.persephoneslair.org> (raw)
Use kzalloc() and avoid a memset().
Signed-off-by: Andrea Shepard <andrea@persephoneslair.org>
diff --git a/drivers/net/wan/pc300_drv.c b/drivers/net/wan/pc300_drv.c
index f6da796..a8f3184 100644
--- a/drivers/net/wan/pc300_drv.c
+++ b/drivers/net/wan/pc300_drv.c
@@ -234,6 +234,7 @@ static char rcsid[] =
#include <linux/etherdevice.h>
#include <linux/spinlock.h>
#include <linux/if.h>
+#include <linux/slab.h>
#include <net/arp.h>
#include <asm/io.h>
@@ -3572,14 +3573,13 @@ cpc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
#endif
}
- card = (pc300_t *) kmalloc(sizeof(pc300_t), GFP_KERNEL);
+ card = kzalloc(sizeof(pc300_t), GFP_KERNEL);
if (card == NULL) {
printk("PC300 found at RAM 0x%08lx, "
"but could not allocate card structure.\n",
pci_resource_start(pdev, 3));
return -ENOMEM;
}
- memset(card, 0, sizeof(pc300_t));
/* read PCI configuration area */
device_id = ent->device;
reply other threads:[~2012-01-30 2:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130025050.GJ10262@cronus.persephoneslair.org \
--to=andrea@persephoneslair.org \
--cc=alan@linux.intel.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=jdmason@kudzu.us \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=justinmattock@gmail.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).