* [02/22] Cyclades PC300 driver: re-enable Kconfig option
@ 2012-01-30 2:44 Andrea Shepard
2012-01-30 14:33 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Andrea Shepard @ 2012-01-30 2:44 UTC (permalink / raw)
To: linux-kernel, netdev
Cc: khc, davem, mmarek, jkosina, joe, justinmattock, gregkh, alan, jdmason
The old pc300 driver had been disabled because it did not build. This patch
re-enables it in Kconfig.
Signed-off-by: Andrea Shepard <andrea@persephoneslair.org>
diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig
index 423eb26..36a439a 100644
--- a/drivers/net/wan/Kconfig
+++ b/drivers/net/wan/Kconfig
@@ -205,10 +205,8 @@ config WANXL_BUILD_FIRMWARE
config PC300
tristate "Cyclades-PC300 support (RS-232/V.35, X.21, T1/E1 boards)"
- depends on HDLC && PCI && BROKEN
+ depends on HDLC && PCI
---help---
- This driver is broken because of struct tty_driver change.
-
Driver for the Cyclades-PC300 synchronous communication boards.
These boards provide synchronous serial interfaces to your
@@ -217,6 +215,10 @@ config PC300
option later and read the file README.mlppp provided by PC300
package.
+ Due to changes in certain ioctls necessary for portability, this
+ version requires a new version of pc300utils, which may be found
+ at: http://charon.persephoneslair.org/~andrea/software/pc300utils/
+
To compile this as a module, choose M here: the module
will be called pc300.
@@ -228,11 +230,8 @@ config PC300_MLPPP
help
Multilink PPP over the PC300 synchronous communication boards.
-comment "Cyclades-PC300 MLPPP support is disabled."
- depends on HDLC && PC300 && (PPP=n || !PPP_MULTILINK || PPP_SYNC_TTY=n || !HDLC_PPP)
-
comment "Refer to the file README.mlppp, provided by PC300 package."
- depends on HDLC && PC300 && (PPP=n || !PPP_MULTILINK || PPP_SYNC_TTY=n || !HDLC_PPP)
+ depends on HDLC && PC300 && (PPP=n || !PPP_MULTILINK || PPP_SYNC_TTY=n || !HDLC_PPP) && PC300_MLPPP
config PC300TOO
tristate "Cyclades PC300 RSV/X21 alternative support"
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [02/22] Cyclades PC300 driver: re-enable Kconfig option
2012-01-30 2:44 [02/22] Cyclades PC300 driver: re-enable Kconfig option Andrea Shepard
@ 2012-01-30 14:33 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2012-01-30 14:33 UTC (permalink / raw)
To: Andrea Shepard
Cc: linux-kernel, netdev, khc, davem, mmarek, jkosina, joe,
justinmattock, alan, jdmason
On Sun, Jan 29, 2012 at 06:44:46PM -0800, Andrea Shepard wrote:
> The old pc300 driver had been disabled because it did not build. This patch
> re-enables it in Kconfig.
But isn't the build still broken at this point in time?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-30 14:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-30 2:44 [02/22] Cyclades PC300 driver: re-enable Kconfig option Andrea Shepard
2012-01-30 14:33 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).