From: Oleg Nesterov <oleg@redhat.com>
To: Christopher Yeoh <cyeoh@au1.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Cleanup of rw_copy_check_uvector and compat_rw_copy_check_uvector
Date: Mon, 30 Jan 2012 18:23:37 +0100 [thread overview]
Message-ID: <20120130172337.GA12696@redhat.com> (raw)
In-Reply-To: <20120130145114.4c084a6a@Gantu.yeoh.info>
On 01/30, Christopher Yeoh wrote:
>
> ssize_t compat_rw_copy_check_uvector(int type,
> const struct compat_iovec __user *uvector, unsigned long nr_segs,
> unsigned long fast_segs, struct iovec *fast_pointer,
> - struct iovec **ret_pointer, int check_access)
> + struct iovec **ret_pointer)
> {
> compat_ssize_t tot_len;
> struct iovec *iov = *ret_pointer = fast_pointer;
> @@ -586,7 +586,7 @@ ssize_t compat_rw_copy_check_uvector(int type,
> }
> if (len < 0) /* size_t not fitting in compat_ssize_t .. */
> goto out;
> - if (check_access &&
> + if (type >=0 &&
I bet checkpatch.pl will complain, this needs the space after '>' ;)
Otherwise this is nice cleanup, imho.
Christopher, this is up to Andrew but perhaps you should update
the changelog. It should explain what this patch does (overload
"int type", remove the unnecessary "check_access", etc). It should
not simply mention the previous discussion.
Oleg.
next prev parent reply other threads:[~2012-01-30 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 4:21 [PATCH] Cleanup of rw_copy_check_uvector and compat_rw_copy_check_uvector Christopher Yeoh
2012-01-30 17:23 ` Oleg Nesterov [this message]
2012-01-30 22:01 ` Andrew Morton
2012-02-01 2:04 ` Christopher Yeoh
2012-04-05 16:40 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130172337.GA12696@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cyeoh@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).