linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Víctor M. Jáquez L." <vjaquez@igalia.com>
To: "Ramirez Luna, Omar" <omar.ramirez@ti.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	Armando Uribe <x0095078@ti.com>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-omap@vger.kernel.org,
	Felipe Contreras <felipe.contreras@gmail.com>,
	Ivan Gomez Castellanos <ivan.gomez@ti.com>
Subject: Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c
Date: Mon, 30 Jan 2012 18:59:40 +0100	[thread overview]
Message-ID: <20120130175940.GG27022@lit.local.igalia.com> (raw)
In-Reply-To: <CAB-zwWjKfakESHw4Cw8JvJ6WpELz51E_9zVtjR0bF84yhMRfMQ@mail.gmail.com>

On Mon, Jan 30, 2012 at 11:25:34AM -0600, Ramirez Luna, Omar wrote:
> 2012/1/23 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>:
> > No functional changes.
> >
> > According to Lindent, the file drv_internface.c had some lines with bad
> > indentation.
> >
> > This commit is the output of Lindent.
> 
> Usually lindent tends to do whatever it wants, unless carefully
> configured...

Thanks Omar!

I'll post a v2 of this patch set, with a couple things more and with more
attention on what lindent does in this one, if that's ok.

vmjl

> 
> ...
> > @@ -342,9 +342,10 @@ static void bridge_recover(struct work_struct *work)
> >        if (atomic_read(&bridge_cref)) {
> >                INIT_COMPLETION(bridge_comp);
> >                while (!wait_for_completion_timeout(&bridge_comp,
> > -                                               msecs_to_jiffies(REC_TIMEOUT)))
> > -                       pr_info("%s:%d handle(s) still opened\n",
> > -                                       __func__, atomic_read(&bridge_cref));
> > +                                                   msecs_to_jiffies
> > +                                                   (REC_TIMEOUT)))
> 
> Like here, it just split msecs_to_jiffies(REC_TIMEOUT) into 2 lines
> making it a little harder to read.
> 
> > +                       pr_info("%s:%d handle(s) still opened\n", __func__,
> > +                               atomic_read(&bridge_cref));
> 
> I remember the rule was to break lines as far to the right as
> possible, no? Chapter 2 CodingStyle, same for the other similar
> changes.
> 
> ...
> > @@ -547,10 +548,9 @@ static int __devexit omap34_xx_bridge_remove(struct platform_device *pdev)
> >                pr_err("%s: Failed to retrieve the object handle\n", __func__);
> >                goto func_cont;
> >        }
> > -
> 
> Blank line removed?
> 
> >  #ifdef CONFIG_TIDSPBRIDGE_DVFS
> >        if (cpufreq_unregister_notifier(&iva_clk_notifier,
> > -                                               CPUFREQ_TRANSITION_NOTIFIER))
> > +                                       CPUFREQ_TRANSITION_NOTIFIER))
> >                pr_err("%s: cpufreq_unregister_notifier failed for iva2_ck\n",
> >                       __func__);
> >  #endif /* #ifdef CONFIG_TIDSPBRIDGE_DVFS */
> > --
> > 1.7.8.3
> >
> 
> Regards,
> 
> Omar
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2012-01-30 17:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-23 20:09 [PATCH 0/5] staging: tidspbridge: clean up drv_interface.c Víctor Manuel Jáquez Leal
2012-01-23 20:09 ` [PATCH 1/5] staging: tidspbridge: more readable code Víctor Manuel Jáquez Leal
2012-01-24 18:22   ` Felipe Contreras
2012-01-30 17:14     ` Ramirez Luna, Omar
2012-01-23 20:09 ` [PATCH 2/5] staging: tidspbridge: remove unused header Víctor Manuel Jáquez Leal
2012-01-24 17:45   ` Felipe Contreras
2012-01-30 17:15     ` Ramirez Luna, Omar
2012-01-23 20:09 ` [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c Víctor Manuel Jáquez Leal
2012-01-30 17:25   ` Ramirez Luna, Omar
2012-01-30 17:59     ` Víctor M. Jáquez L. [this message]
2012-01-30 19:29     ` Dan Carpenter
2012-01-30 19:53       ` Joe Perches
2012-01-30 20:33         ` Víctor M. Jáquez L.
2012-01-30 20:40           ` Joe Perches
2012-01-23 20:09 ` [PATCH 4/5] staging: tidspbridge: silence the compiler Víctor Manuel Jáquez Leal
2012-01-30 17:28   ` Ramirez Luna, Omar
2012-01-23 20:09 ` [PATCH 5/5] staging: tidspbridge: remove header inclusions Víctor Manuel Jáquez Leal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120130175940.GG27022@lit.local.igalia.com \
    --to=vjaquez@igalia.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=felipe.contreras@gmail.com \
    --cc=gregkh@suse.de \
    --cc=ivan.gomez@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=omar.ramirez@ti.com \
    --cc=x0095078@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).