From: Anton Vorontsov <email@example.com>
To: Greg KH <firstname.lastname@example.org>
Cc: "Arve Hjønnevåg" <email@example.com>,
"KOSAKI Motohiro" <firstname.lastname@example.org>,
"San Mehat" <email@example.com>, "Colin Cross" <firstname.lastname@example.org>,
"Oleg Nesterov" <email@example.com>,
"Eric W. Biederman" <firstname.lastname@example.org>,
Subject: Re: [PATCH 1/3] procfs: Export next_tgid(), move it to kernel/pid.c
Date: Mon, 30 Jan 2012 23:50:33 +0400 [thread overview]
Message-ID: <20120130195033.GA1557@oksana.dev.rtsoft.ru> (raw)
On Sun, Jan 29, 2012 at 06:22:42PM -0800, Greg KH wrote:
> On Mon, Jan 30, 2012 at 05:13:23AM +0400, Anton Vorontsov wrote:
> > We'd like to use this function in the android low memory killer driver, so
> > let's export it.
> Why is it needed?
> I _REALLY_ don't want to add any exports to any part of the kernel for
> the android low memory stuff. That is because it is not something that
> should be touching anything else, especially as numerous people disagree
> with what it does and how it does it.
> Instead, you should be spending the time and effort to properly
> implement this, as has been discussed numerous times, the last one a
> mere few weeks ago when someone tried adding the nokia-specific low
> memory killer/notifier code.
Yep, and I fully agree here. But doing it the right way (i.e. teaching
Android to use low memory notifiers) will take some time. And improving
current driver meanwhile is just my sub-task.
> So no, sorry, I will not take these patches, unless you come up with
> some very good justifications why.
Well, actually, this patches were born as a response to LMK review
by KOSAKI Motohiro, he did not like the tasklist lock. Though, I agree
that it might be not a great idea to export API for the driver that
is about to superseded by a different approach (i.e. notifiers). :-)
Heh. But you never know where you'll end up before you actually
try to do something. I have tried to get rid of the tacklist lock,
and it appears that it causes more trouble. :-)
next prev parent reply other threads:[~2012-01-30 19:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 1:13 [PATCH 1/3] procfs: Export next_tgid(), move it to kernel/pid.c Anton Vorontsov
2012-01-30 2:22 ` Greg KH
2012-01-30 19:50 ` Anton Vorontsov [this message]
2012-01-30 3:26 ` Eric W. Biederman
2012-01-30 19:51 ` Anton Vorontsov
2012-01-30 13:43 ` Oleg Nesterov
2012-01-30 20:49 ` Anton Vorontsov
2012-01-31 1:51 ` Eric W. Biederman
2012-02-01 4:19 ` Anton Vorontsov
2012-02-01 4:37 ` Eric W. Biederman
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).