linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Zhang Yanmin <yanmin_zhang@linux.intel.com>
Cc: Stephane Eranian <eranian@google.com>,
	linux-kernel@vger.kernel.org, peterz@infradead.org,
	mingo@elte.hu, robert.richter@amd.com,
	Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] perf: fix broken perf inject -b
Date: Mon, 30 Jan 2012 18:36:54 -0200	[thread overview]
Message-ID: <20120130203653.GD5797@infradead.org> (raw)
In-Reply-To: <CABPqkBQu=82igQV2O_UmJsuDOHh8_VyRQCUGmrGqTBvnEdyN+Q@mail.gmail.com>

Em Mon, Jan 30, 2012 at 09:09:17PM +0100, Stephane Eranian escreveu:
> On Mon, Jan 30, 2012 at 9:04 PM, Arnaldo Carvalho de Melo
> <acme@redhat.com> wrote:
> > Em Mon, Jan 30, 2012 at 08:53:26PM +0100, Stephane Eranian escreveu:
> >> On Mon, Jan 30, 2012 at 8:00 PM, Arnaldo Carvalho de Melo
> >> <acme@redhat.com> wrote:
> >> > > >>> @@ -173,6 +178,7 @@ static int perf_event__inject_buildid(struct perf_tool *tool,
> >> > > >>>               goto repipe;
> >> > > >>>       }
> >> > > >>> +     machine->pid = event->ip.pid;
> >> >
> >> > > I noticed that this statement conflicts with perf buildid-list (which
> >> > > I am also fixing for pipe mode).

> >> > > I don't quite understand why, though.

> >> > Have you reached any conclusion about this problem? I haven't looked at
> >> > it in detail, could you please elaborate more?

> >> I ended up removing it. But I am not sure this is correct.
> >> Is the pid used in any way when processing buildids?
> >
> > I can't think of any.
> >
> > The same DSO could conceivably be present in the virtual machine, the
> > host, and in the workstation used for perf report.  We just use the
> > build-id in the perf.data file to find the right symtab.

> Right, so I don't know why it's there...

This comes from a1645ce1:

commit a1645ce12adb6c9cc9e19d7695466204e3f017fe
Author: Zhang, Yanmin <yanmin_zhang@linux.intel.com>
Date:   Mon Apr 19 13:32:50 2010 +0800

    perf: 'perf kvm' tool for monitoring guest performance from host
    
    Here is the patch of userspace perf tool.
    
    Signed-off-by: Zhang Yanmin <yanmin_zhang@linux.intel.com>
    Signed-off-by: Avi Kivity <avi@redhat.com>



Zhang, what was the thinking about that pid in the buildid event?

>From what I can see we can just ignore it :-\

- Arnaldo

  reply	other threads:[~2012-01-30 20:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-13 14:47 [PATCH] perf: fix broken perf inject -b Stephane Eranian
2012-01-13 16:53 ` Arnaldo Carvalho de Melo
2012-01-13 16:54   ` Stephane Eranian
2012-01-16 18:53     ` Stephane Eranian
2012-01-30 19:00       ` Arnaldo Carvalho de Melo
2012-01-30 19:53         ` Stephane Eranian
2012-01-30 20:04           ` Arnaldo Carvalho de Melo
2012-01-30 20:09             ` Stephane Eranian
2012-01-30 20:36               ` Arnaldo Carvalho de Melo [this message]
2012-01-31  5:58                 ` Yanmin Zhang
2012-02-02 11:22                   ` Stephane Eranian
2012-02-03  3:30                     ` Yanmin Zhang
2012-01-26 14:16     ` Stephane Eranian
2012-01-26 14:23       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120130203653.GD5797@infradead.org \
    --to=acme@redhat.com \
    --cc=avi@redhat.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=robert.richter@amd.com \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).