linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: remove .. in perf includes/
Date: Mon, 30 Jan 2012 21:57:52 -0200	[thread overview]
Message-ID: <20120130235752.GE5797@infradead.org> (raw)
In-Reply-To: <4F270F67.4070809@linux.intel.com>

Em Mon, Jan 30, 2012 at 01:45:11PM -0800, Andi Kleen escreveu:
> On 1/30/2012 11:14 AM, Arnaldo Carvalho de Melo wrote:
>> Em Fri, Jan 20, 2012 at 12:36:44PM -0800, Andi Kleen escreveu:
>>> From: Andi Kleen<ak@linux.intel.com>
>>> - Add all the relevant directories as -I in the Makefile
>>> - Remove (near) all the .. in include statements
>>> - Remove unnecessary wrappers that do nothing
>>> - Fix up some fallout
>>>
>>> This makes the code more pleasant to read.
>>>
>>> I did it all in one big patch to keep bisectability.
>> It builds, but breaks this:
>
> Hmm cannot reproduce. The extra tarball builds fine and includes memset_64.S
> with my patch on Linus latest.

Humm, there was a patch for 'perf bench' that came after your patch and
I applied before yours, I bet that is the problem, I'll get that
checked.

Thanks,

- Arnaldo

      reply	other threads:[~2012-01-30 23:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20 20:36 [PATCH] perf tools: remove .. in perf includes/ Andi Kleen
2012-01-30 19:14 ` Arnaldo Carvalho de Melo
2012-01-30 21:45   ` Andi Kleen
2012-01-30 23:57     ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120130235752.GE5797@infradead.org \
    --to=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).