From: Wolfram Sang <w.sang@pengutronix.de>
To: Roland Stigge <stigge@antcom.de>
Cc: bangaragiri.g@nxp.com, srinivas.bakki@nxp.com,
sundarapandian.andithevar@nxp.com, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, kevin.wells@nxp.com,
grant.likely@secretlab.ca, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/7] LPC32xx: clock.c: warning fix
Date: Tue, 31 Jan 2012 11:26:58 +0100 [thread overview]
Message-ID: <20120131102658.GH2471@pengutronix.de> (raw)
In-Reply-To: <1327939327-7799-5-git-send-email-stigge@antcom.de>
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
On Mon, Jan 30, 2012 at 05:02:04PM +0100, Roland Stigge wrote:
> This patch removes the debug warning on local_clk_disable() as done in Kevin
> Wells' driver update
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
Maybe this can be folded with 7/7? Otherwise
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
Tested-by: Wolfram Sang <w.sang@pengutronix.de>
>
> diff --git a/arch/arm/mach-lpc32xx/clock.c b/arch/arm/mach-lpc32xx/clock.c
> index 229bec5..01e9aba 100644
> --- a/arch/arm/mach-lpc32xx/clock.c
> +++ b/arch/arm/mach-lpc32xx/clock.c
> @@ -903,8 +903,6 @@ static inline void clk_unlock(void)
>
> static void local_clk_disable(struct clk *clk)
> {
> - WARN_ON(clk->usecount == 0);
> -
> /* Don't attempt to disable clock if it has no users */
> if (clk->usecount > 0) {
> clk->usecount--;
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-01-31 10:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 16:02 [PATCH v2 1/7] LPC32xx: clock.c: Missing header file Roland Stigge
2012-01-30 16:02 ` [PATCH v2 2/7] LPC32xx: clock.c: jiffies wrapping Roland Stigge
2012-01-31 10:24 ` Wolfram Sang
2012-01-30 16:02 ` [PATCH v2 3/7] LPC32xx: clock.c: Clock registration fixes Roland Stigge
2012-01-30 16:02 ` [PATCH v2 4/7] LPC32xx: clock.c: MMC update Roland Stigge
2012-01-30 16:02 ` [PATCH v2 5/7] LPC32xx: clock.c: warning fix Roland Stigge
2012-01-31 10:26 ` Wolfram Sang [this message]
2012-01-30 16:02 ` [PATCH v2 6/7] LPC32xx: clock.c: USB PLL fix Roland Stigge
2012-01-31 10:34 ` Wolfram Sang
2012-02-01 13:27 ` Roland Stigge
2012-02-02 16:49 ` Wolfram Sang
2012-02-02 19:20 ` Roland Stigge
2012-02-02 23:01 ` Wolfram Sang
2012-01-30 16:02 ` [PATCH v2 7/7] LPC32xx: clock.c: Fix mutex lock issues Roland Stigge
2012-01-31 10:27 ` Wolfram Sang
2012-01-30 17:56 ` [PATCH v2 1/7] LPC32xx: clock.c: Missing header file Sergei Shtylyov
2012-01-31 10:22 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131102658.GH2471@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=bangaragiri.g@nxp.com \
--cc=grant.likely@secretlab.ca \
--cc=kevin.wells@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.bakki@nxp.com \
--cc=stigge@antcom.de \
--cc=sundarapandian.andithevar@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).