From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754996Ab2AaTc5 (ORCPT ); Tue, 31 Jan 2012 14:32:57 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:33600 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752803Ab2AaTc4 (ORCPT ); Tue, 31 Jan 2012 14:32:56 -0500 Date: Tue, 31 Jan 2012 11:32:50 -0800 From: Andrew Morton To: Christoph Hellwig Cc: Niels de Vos , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro , Mikulas Patocka , Jeff Moyer , "Bryn M. Reeves" Subject: Re: [PATCH v3] fs: Invalidate the cache for a parent block-device if fsync() is called for a partition Message-Id: <20120131113250.816ee772.akpm@linux-foundation.org> In-Reply-To: <20120131190425.GA10533@infradead.org> References: <4F213E1A.4060808@redhat.com> <1327584802-14298-1-git-send-email-ndevos@redhat.com> <20120126134051.6add3cd2.akpm@linux-foundation.org> <20120126214534.GA9319@infradead.org> <4F28102C.1070207@redhat.com> <20120131105824.c48351b6.akpm@linux-foundation.org> <20120131190425.GA10533@infradead.org> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Jan 2012 14:04:25 -0500 Christoph Hellwig wrote: > On Tue, Jan 31, 2012 at 10:58:24AM -0800, Andrew Morton wrote: > > One concern I have with the proposal is that it would forever rule out > > support of >16T devices on 32-bit machines. > > > > At present with 64-bit sector_t and 32-bit pgoff_t, I think we'd have a > > reasonable chance of supporting, say, four 8T partitions on a 32T > > device. But if we were to switch the kernel from using four 4T > > address_spaces (sda1-4) over to using a single 32T address_space (sda) > > then we can rule it all out. > > how do you plan to write the partition label in your hypothetic setup > if you can't open the main device? > > And even if we solved that and people could create partitions on these > devices but not open the main device, or use large lvm volumes it would > be an absolutely major confusion. > I didn't say the kernel would support this as-is. If the partitioning scheme requires writing to the individual partitions then something would need to be done, such as a simple offsetting DM driver.