From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen pvhvm: do not remap pirqs onto evtchns if !xen_have_vector_callback
Date: Tue, 31 Jan 2012 11:27:59 -0500 [thread overview]
Message-ID: <20120131162759.GA18248@phenom.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1201301429530.3196@kaball-desktop>
On Mon, Jan 30, 2012 at 02:31:46PM +0000, Stefano Stabellini wrote:
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
So the xen_have_vector_callback looks to be only set by
1398 if (xen_feature(XENFEAT_hvm_callback_vector))
1399 xen_have_vector_callback = 1;
So could this be just done via a check for that instead?
>
> diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
> index 492ade8..d99346e 100644
> --- a/arch/x86/pci/xen.c
> +++ b/arch/x86/pci/xen.c
> @@ -374,7 +374,7 @@ int __init pci_xen_init(void)
>
> int __init pci_xen_hvm_init(void)
> {
> - if (!xen_feature(XENFEAT_hvm_pirqs))
> + if (!xen_have_vector_callback || !xen_feature(XENFEAT_hvm_pirqs))
> return 0;
>
> #ifdef CONFIG_ACPI
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2012-01-31 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 14:31 [PATCH] xen pvhvm: do not remap pirqs onto evtchns if !xen_have_vector_callback Stefano Stabellini
2012-01-31 16:27 ` Konrad Rzeszutek Wilk [this message]
2012-01-31 16:40 ` Stefano Stabellini
2012-02-01 1:08 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-02-01 11:09 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131162759.GA18248@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).