From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755640Ab2BAHIx (ORCPT ); Wed, 1 Feb 2012 02:08:53 -0500 Received: from shards.monkeyblade.net ([198.137.202.13]:56209 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752859Ab2BAHIw (ORCPT ); Wed, 1 Feb 2012 02:08:52 -0500 Date: Wed, 01 Feb 2012 02:07:38 -0500 (EST) Message-Id: <20120201.020738.1965865410881089752.davem@davemloft.net> To: lizf@cn.fujitsu.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, nhorman@tuxdriver.com Subject: Re: [PATCH 4/6] netprio_cgroup: use IS_ENABLED() and family From: David Miller In-Reply-To: <4F28E48D.3040505@cn.fujitsu.com> References: <4F28E203.10502@cn.fujitsu.com> <20120201.015954.2098592611164231843.davem@davemloft.net> <4F28E48D.3040505@cn.fujitsu.com> X-Mailer: Mew version 6.4 on Emacs 23.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Tue, 31 Jan 2012 23:07:40 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Li Zefan Date: Wed, 01 Feb 2012 15:06:53 +0800 > 14:59, David Miller wrote: >> >> Do not mix genuine bug fixes and cleanups. >> >> Otherwise I cannot apply your bug fixes to the 'net' tree. >> >> Seperate things out, submit only pure bug fixes first, then >> later once those changes propagate you can submit the cleanups. >> > > I did seperate them out, so the first three patches are fixes, > and others are cleanups. I can resend cleanup patches once > fixes hit mainline. Seperate them in different groups, don't submit them as one collection. And definitely don't submit them all at the same damn time! You have to wait with the dependent cleanups until the fixes go in, and subsequently show up in my net-next tree. I'm not applying this stuff until you submit it properly, in two stages.