From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: dev: Convert printks to pr_<level>
Date: Wed, 01 Feb 2012 14:21:56 -0500 (EST) [thread overview]
Message-ID: <20120201.142156.871464551711177387.davem@davemloft.net> (raw)
In-Reply-To: <1327882830.2652.16.camel@joe2Laptop>
From: Joe Perches <joe@perches.com>
Date: Sun, 29 Jan 2012 16:20:30 -0800
> - pr_warning("Number of in use tx queues changed "
> - "invalidating tc mappings. Priority "
> - "traffic classification disabled!\n");
> + pr_warn(
> +"Number of in use tx queues changed invalidating tc mappings. "
> +"Priority traffic classification disabled!\n");
Don't do things like this. It is never correct to un-indent subsequent
lines of a string like this. And a line ending in "pr_whatever(" looks
terrible.
next prev parent reply other threads:[~2012-02-01 19:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 22:56 [PATCH net-next] drivers/net: Remove unnecessary k.alloc/v.alloc OOM messages Joe Perches
2012-01-29 23:47 ` [PATCH net-next] drivers/net: Remove alloc_etherdev error messages Joe Perches
2012-01-30 0:20 ` [PATCH net-next] net: dev: Convert printks to pr_<level> Joe Perches
2012-02-01 19:21 ` David Miller [this message]
2012-02-01 19:40 ` Joe Perches
2012-02-01 19:43 ` David Miller
2012-02-01 20:54 ` PATCH V2 " Joe Perches
2012-02-01 20:57 ` David Miller
2012-01-31 21:41 ` [PATCH net-next] drivers/net: Remove alloc_etherdev error messages David Miller
2012-01-31 21:41 ` [PATCH net-next] drivers/net: Remove unnecessary k.alloc/v.alloc OOM messages David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201.142156.871464551711177387.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).