From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
Michel Jaouen <michel.jaouen@stericsson.com>,
Maxime Coquelin <maxime.coquelin@st-ericsson.com>,
Alex Macro <alex.macro@stericsson.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] mfd/ab8500: support AB9540 variant
Date: Wed, 1 Feb 2012 11:31:55 +0000 [thread overview]
Message-ID: <20120201113154.GA13723@sirena.org.uk> (raw)
In-Reply-To: <1328094155-3320-1-git-send-email-linus.walleij@stericsson.com>
On Wed, Feb 01, 2012 at 12:02:35PM +0100, Linus Walleij wrote:
> identifier field. If possible, we fall back on auto-detecting
> the AB variant. The necessary deviations are factored into
> the driver and board data.
This seems a bit weird - I would expect the silicon to be more accurate
than user provided platform data. I'd expect the driver to always check
the information provided by the device and at least log if there's a
difference.
It'd also be easier to review the patch if there was some description of
the differences (or there were a series of patches adding
parameterisation for relevant things followed by one adding the new
device).
next prev parent reply other threads:[~2012-02-01 11:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 11:02 [PATCH] mfd/ab8500: support AB9540 variant Linus Walleij
2012-02-01 11:31 ` Mark Brown [this message]
2012-02-01 14:42 ` Linus Walleij
2012-02-01 14:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201113154.GA13723@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alex.macro@stericsson.com \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@st-ericsson.com \
--cc=michel.jaouen@stericsson.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).