From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: care sd_dma_address/len in dmaengine_prep_slave_single()
Date: Wed, 1 Feb 2012 18:22:01 +0000 [thread overview]
Message-ID: <20120201182201.GE889@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <87pqe04qtk.wl%kuninori.morimoto.gx@renesas.com>
On Mon, Jan 30, 2012 at 05:13:30PM -0800, Kuninori Morimoto wrote:
> + sg_init_table(&sg, 1);
> + sg_set_page(&sg, pfn_to_page(PFN_DOWN(buf)),
> + len, offset_in_page(buf));
There's not much point setting this - the page/virtual address should
not be used by DMA engines as that may not reflect what's being requested
(especially if there's an IOMMU in the way.)
next prev parent reply other threads:[~2012-02-01 18:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 9:25 [PATCH] dmaengine: care sd_dma_address/len in dmaengine_prep_slave_single() Kuninori Morimoto
2012-01-30 9:56 ` Vinod Koul
2012-01-31 1:13 ` [PATCH v2] " Kuninori Morimoto
2012-02-01 18:22 ` Russell King - ARM Linux [this message]
2012-04-25 14:18 ` Lars-Peter Clausen
2012-04-25 14:29 ` Russell King - ARM Linux
2012-03-08 9:48 ` Lars-Peter Clausen
2012-03-09 0:18 ` Kuninori Morimoto
2012-03-10 11:12 ` Lars-Peter Clausen
2012-03-13 0:46 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201182201.GE889@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=dan.j.williams@intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).