From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933159Ab2BAWZZ (ORCPT ); Wed, 1 Feb 2012 17:25:25 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33795 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932069Ab2BAWZX (ORCPT ); Wed, 1 Feb 2012 17:25:23 -0500 X-Sasl-enc: qav2zsmPO4dg0MqS27xLEO2UJ3ZVKv++uCWeU/M1usRC 1328135122 Date: Wed, 1 Feb 2012 14:24:41 -0800 From: Greg Kroah-Hartman To: "Eric W. Biederman" Cc: Jiri Slaby , Alan Cox , LKML , Al Viro , Linus Torvalds , Maciej Rutecki Subject: Re: [PATCH] sysfs: Optionally count subdirectories to support buggy applications Message-ID: <20120201222441.GB2333@kroah.com> References: <4F27120A.4040106@suse.cz> <20120130220611.GA26655@kroah.com> <20120130221059.26ab5edf@pyramind.ukuu.org.uk> <20120130222717.GA6393@kroah.com> <4F27C6EB.2070305@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 01, 2012 at 02:21:59PM -0800, Eric W. Biederman wrote: > > lm_sensors and possibly other applications get confused if all sysfs > directories return nlink == 1. The lm_sensors code that got confused > was just wrong and a fixed version of lm_sensors should be released > shortly. > > There may be other applications that have problems with sysfs return > nlink == 1 for directories. To allow people to continue to use old > versions of userspace with new kernels add to sysfs a compile time > option to maintain mostly precise directory counts for those people who > don't mind the cost. > > I have moved where we keep nlink in sysfs_dirent as compared to previous > versions of subdirectory counting to a location that packs better. > > Signed-off-by: Eric W. Biederman > --- > fs/sysfs/Kconfig | 15 +++++++++++++++ > fs/sysfs/dir.c | 8 ++++++++ > fs/sysfs/inode.c | 2 ++ > fs/sysfs/sysfs.h | 38 ++++++++++++++++++++++++++++++++++++++ > 4 files changed, 63 insertions(+), 0 deletions(-) > > diff --git a/fs/sysfs/Kconfig b/fs/sysfs/Kconfig > index 8c41fea..9b403e9 100644 > --- a/fs/sysfs/Kconfig > +++ b/fs/sysfs/Kconfig > @@ -21,3 +21,18 @@ config SYSFS > example, "root=03:01" for /dev/hda1. > > Designers of embedded systems may wish to say N here to conserve space. > + > +config SYSFS_COUNT_LINKS > + bool "sysfs count subdirectoires to support buggy applications" > + default n As we don't want to break things, this should be default y, right? Also, should we list this in the feature_removal list as well so that we can get rid of it in a year or so? thanks, greg k-h