* [PATCH] powerpc: Define cpus_in_crash only for SMP kernels
@ 2012-02-01 18:55 Paul E. McKenney
2012-02-01 20:28 ` Paul Gortmaker
0 siblings, 1 reply; 3+ messages in thread
From: Paul E. McKenney @ 2012-02-01 18:55 UTC (permalink / raw)
To: linuxppc-dev; +Cc: linux-kernel, paulus, anton, paul.gortmaker, ben, mikey
The variable cpus_in_crash gets a defined-but-not-used warning when
CONFIG_SMP=n, so fix by placing the variable under ifdef.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
index 28be345..eb3384e 100644
--- a/arch/powerpc/kernel/crash.c
+++ b/arch/powerpc/kernel/crash.c
@@ -46,7 +46,9 @@
/* This keeps a track of which one is the crashing cpu. */
int crashing_cpu = -1;
+#ifdef CONFIG_SMP
static atomic_t cpus_in_crash;
+#endif /* #ifdef CONFIG_SMP */
static int time_to_dump;
#define CRASH_HANDLER_MAX 3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Define cpus_in_crash only for SMP kernels
2012-02-01 18:55 [PATCH] powerpc: Define cpus_in_crash only for SMP kernels Paul E. McKenney
@ 2012-02-01 20:28 ` Paul Gortmaker
2012-02-01 23:15 ` Paul E. McKenney
0 siblings, 1 reply; 3+ messages in thread
From: Paul Gortmaker @ 2012-02-01 20:28 UTC (permalink / raw)
To: paulmck; +Cc: linuxppc-dev, linux-kernel, paulus, anton, ben, mikey
On 12-02-01 01:55 PM, Paul E. McKenney wrote:
> The variable cpus_in_crash gets a defined-but-not-used warning when
> CONFIG_SMP=n, so fix by placing the variable under ifdef.
I think Ben already merged a similar fix.
http://patchwork.ozlabs.org/patch/136549/
P.
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
> index 28be345..eb3384e 100644
> --- a/arch/powerpc/kernel/crash.c
> +++ b/arch/powerpc/kernel/crash.c
> @@ -46,7 +46,9 @@
>
> /* This keeps a track of which one is the crashing cpu. */
> int crashing_cpu = -1;
> +#ifdef CONFIG_SMP
> static atomic_t cpus_in_crash;
> +#endif /* #ifdef CONFIG_SMP */
> static int time_to_dump;
>
> #define CRASH_HANDLER_MAX 3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Define cpus_in_crash only for SMP kernels
2012-02-01 20:28 ` Paul Gortmaker
@ 2012-02-01 23:15 ` Paul E. McKenney
0 siblings, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2012-02-01 23:15 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linuxppc-dev, linux-kernel, paulus, anton, ben, mikey
On Wed, Feb 01, 2012 at 03:28:34PM -0500, Paul Gortmaker wrote:
> On 12-02-01 01:55 PM, Paul E. McKenney wrote:
> > The variable cpus_in_crash gets a defined-but-not-used warning when
> > CONFIG_SMP=n, so fix by placing the variable under ifdef.
>
> I think Ben already merged a similar fix.
>
> http://patchwork.ozlabs.org/patch/136549/
>
> P.
Linus's tree does now have cpus_in_crash, so agreed. Sorry for the
noise!
Thanx, Paul
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >
> > diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
> > index 28be345..eb3384e 100644
> > --- a/arch/powerpc/kernel/crash.c
> > +++ b/arch/powerpc/kernel/crash.c
> > @@ -46,7 +46,9 @@
> >
> > /* This keeps a track of which one is the crashing cpu. */
> > int crashing_cpu = -1;
> > +#ifdef CONFIG_SMP
> > static atomic_t cpus_in_crash;
> > +#endif /* #ifdef CONFIG_SMP */
> > static int time_to_dump;
> >
> > #define CRASH_HANDLER_MAX 3
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-01 23:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-01 18:55 [PATCH] powerpc: Define cpus_in_crash only for SMP kernels Paul E. McKenney
2012-02-01 20:28 ` Paul Gortmaker
2012-02-01 23:15 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).