From: Wolfram Sang <w.sang@pengutronix.de>
To: rtc-linux@googlegroups.com
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [rtc-linux] Re: [PATCH v3] rtc: ds1307: generalise ram size and offset
Date: Thu, 2 Feb 2012 15:53:53 +0100 [thread overview]
Message-ID: <20120202145353.GC9648@pengutronix.de> (raw)
In-Reply-To: <1328143057.3159.34.camel@pc786-ubu.gnet.global.vpn>
[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]
Hi Austin,
> I'm sorry about the slow response - I was away at linux.conf.au and then
> haven't found enough time since I got back.
Don't worry, I understand.
> > ... that nvram is static and we are changing it. Yeah, it is very unlikely but
> > if we have two RTC with different nvram sizes, one of them will not work correctly.
> I see the issue. Am I right that it would only occur when you have two
> I2C buses, each with one of the RTC chips supported by this driver?
Basically yes. They could be on one bus, though, using different addresses.
> The fix I thought of would be to add a 'struct bin_attribute' pointer to
> 'struct ds1307' and then in the probe function allocate the structure,
> set the size & callbacks, and pass it as an argument to
> sysfs_create_bin_file. Do you think this is viable?
Yes.
> It looks like Andrew Morton has already added this patch to the -mm
> tree. Has he also grabbed the patches that this depends on?
I will check that and mail him later today.
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-02-02 14:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 21:21 [PATCH v3] rtc: ds1307: generalise ram size and offset Austin Boyle
2012-01-09 22:17 ` Wolfram Sang
2012-01-10 0:33 ` Austin Boyle
2012-01-11 11:06 ` Wolfram Sang
2012-01-11 22:21 ` Austin Boyle
2012-01-18 21:41 ` Wolfram Sang
2012-01-19 19:45 ` Wolfram Sang
2012-02-02 0:37 ` Austin Boyle
2012-02-02 14:53 ` Wolfram Sang [this message]
2012-02-02 22:28 ` Austin Boyle
2012-02-07 14:56 ` Wolfram Sang
2012-02-07 21:45 ` Austin Boyle
2012-02-08 22:23 ` [PATCH v4] " Austin Boyle
2012-02-08 22:36 ` Andrew Morton
2012-02-13 14:36 ` Wolfram Sang
2012-02-14 4:23 ` Austin Boyle
2012-02-21 14:00 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202145353.GC9648@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).