From: Josh Triplett <josh@joshtriplett.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, Valdis.Kletnieks@vt.edu,
dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com,
fweisbec@gmail.com, patches@linaro.org
Subject: Re: [PATCH RFC 0/3] Fix cpuidle_idle_call() RCU usage
Date: Thu, 2 Feb 2012 18:43:46 -0800 [thread overview]
Message-ID: <20120203024346.GE13456@leaf> (raw)
In-Reply-To: <20120203011208.GA2004@linux.vnet.ibm.com>
On Thu, Feb 02, 2012 at 05:12:08PM -0800, Paul E. McKenney wrote:
> This patch series is a second attempt to fix the idle-loop uses of RCU,
> see https://lkml.org/lkml/2012/2/1/741 for v1. Where the first series
> attempted to drive rcu_idle_enter() and rcu_idle_exit() further down
> into the Linux kernels multitude of idle loops, this patch instead
> marks specific idle-loop operations containing RCU read-side critical
> sections, as suggested by Nicolas Pitre and Steven Rostedt. The possibility
> of code shared between idle and non-idle also requires the ability to nest
> rcu_idle_enter() calls. The individual patches are as follows:
>
> 1. Allow nesting of rcu_idle_enter() and rcu_idle_exit().
> 2. Add an RCU_NONIDLE() macro to enclose idle-loop code that
> contains RCU read-side critical sections.
> 3. Use RCU_NONIDLE() to protect cpuidle_idle_call()'s tracepoints.
>
> This patchset has the distinct advantage of avoiding touching any
> architecture-specific code. ;-)
>
> Thanx, Paul
>
> ------------------------------------------------------------------------
>
> b/drivers/cpuidle/cpuidle.c | 12 ++++++++----
> b/include/linux/rcupdate.h | 27 +++++++++++++++++++++++++++
> b/kernel/rcu.h | 18 +++++++++++++++++-
> b/kernel/rcutiny.c | 16 ++++++++++++----
> b/kernel/rcutree.c | 19 +++++++++++++------
> kernel/rcutiny.c | 2 ++
> kernel/rcutree.c | 2 ++
> 7 files changed, 81 insertions(+), 15 deletions(-)
Looks good to me. Much cleaner.
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
prev parent reply other threads:[~2012-02-03 2:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 1:12 [PATCH RFC 0/3] Fix cpuidle_idle_call() RCU usage Paul E. McKenney
2012-02-03 1:12 ` [PATCH RFC tip/core/rcu 1/3] rcu: Allow nesting of rcu_idle_enter() and rcu_idle_exit() Paul E. McKenney
2012-02-03 1:12 ` [PATCH RFC tip/core/rcu 2/3] rcu: Add RCU_NONIDLE() for idle-loop RCU read-side critical sections Paul E. McKenney
2012-02-03 1:12 ` [PATCH RFC tip/core/rcu 3/3] cpuidle: Inform RCU of " Paul E. McKenney
2012-02-03 11:02 ` Deepthi Dharwar
2012-02-03 2:43 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120203024346.GE13456@leaf \
--to=josh@joshtriplett.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=darren@dvhart.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=patches@linaro.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).